Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1178703008: Revert of Add CHECKs to verify that we never finalize stale copies of external strings (Closed)

Created:
5 years, 6 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 6 months ago
Reviewers:
ulan
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Add CHECKs to verify that we never finalize stale copies of external strings (patchset #1 id:1 of https://codereview.chromium.org/1160253010/) Reason for revert: not needed anymore Original issue's description: > Add CHECKs to verify that we never finalize stale copies of external strings > > BUG=none > R=ulan@chromium.org > LOG=n > > Committed: https://crrev.com/ca2f8d811ca08783e38ce5dd42d38a6b6a7b876f > Cr-Commit-Position: refs/heads/master@{#28811} TBR=ulan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Committed: https://crrev.com/6a63a6d4cf652667963c5fdf35e10eee399fcd61 Cr-Commit-Position: refs/heads/master@{#28932}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M src/heap/mark-compact.cc View 1 chunk +1 line, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jochen (gone - plz use gerrit)
Created Revert of Add CHECKs to verify that we never finalize stale copies of external ...
5 years, 6 months ago (2015-06-11 09:37:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1178703008/1
5 years, 6 months ago (2015-06-11 09:37:26 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-11 09:37:35 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-11 09:37:56 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6a63a6d4cf652667963c5fdf35e10eee399fcd61
Cr-Commit-Position: refs/heads/master@{#28932}

Powered by Google App Engine
This is Rietveld 408576698