Issue 1178703002: Abstract out the AppView logic in fn so that it can also be used in non-pure-fn apps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1178703002: Abstract out the AppView logic in fn so that it can also be used in non-pure-fn apps. (Closed)

Created:
5 years, 6 months ago by Hixie

Modified:
5 years, 6 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Abstract out the AppView logic in fn so that it can also be used in non-pure-fn apps. This lays the groundwork for using fn widgets in static environments. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/4cd74ac9336a8f3296f5c3a30db283858579d2a5

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+96 lines, -18 lines)			Patch
M	sky/examples/stocks2/lib/stock_app.dart	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	sky/sdk/lib/framework/app.dart	View		2 chunks	+8 lines, -1 line	0 comments	Download
M	sky/sdk/lib/framework/fn2.dart	View	1	3 chunks	+88 lines, -15 lines	0 comments	Download

Total messages: 3 (1 generated)

Hixie

5 years, 6 months ago (2015-06-10 22:55:29 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
4cd74ac9336a8f3296f5c3a30db283858579d2a5 (presubmit successful).