Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 11787029: Remove the socket_count parameter from NaCl Launch IPC messages. (Closed)

Created:
7 years, 11 months ago by jvoung (off chromium)
Modified:
7 years, 11 months ago
Reviewers:
Mark Seaborn, brettw
CC:
chromium-reviews, yusukes+watch_chromium.org, yzshen+watch_chromium.org, darin-cc_chromium.org, raymes+watch_chromium.org, piman+watch_chromium.org, native-client-reviews_googlegroups.com, ihf+watch_chromium.org
Visibility:
Public.

Description

Remove the socket_count parameter from NaCl Launch IPC messages. After some refactoring, the socket_count is now hardcoded to 1, so we can assume there is only a single socket and avoid using a vector as well. BUG= http://code.google.com/p/nativeclient/issues/detail?id=3241 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175821

Patch Set 1 #

Total comments: 2

Patch Set 2 : socket_for_sel_ldr #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -92 lines) Patch
M chrome/browser/nacl_host/nacl_process_host.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/nacl_host/nacl_process_host.cc View 1 8 chunks +49 lines, -59 lines 0 comments Download
M chrome/browser/renderer_host/chrome_render_message_filter.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/chrome_render_message_filter.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/common/render_messages.h View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/renderer/pepper/ppb_nacl_private_impl.cc View 3 chunks +5 lines, -9 lines 0 comments Download
M ppapi/api/private/ppb_nacl_private.idl View 2 chunks +4 lines, -5 lines 0 comments Download
M ppapi/c/private/ppb_nacl_private.h View 3 chunks +5 lines, -6 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/nacl_entry_points.h View 1 chunk +1 line, -2 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/sel_ldr_launcher_chrome.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jvoung (off chromium)
7 years, 11 months ago (2013-01-08 00:27:39 UTC) #1
Mark Seaborn
I've set BUG=http://code.google.com/p/nativeclient/issues/detail?id=3241 -- it's appropriate, since this cleanup was motivated by that issue. It's ...
7 years, 11 months ago (2013-01-08 00:40:57 UTC) #2
jvoung (off chromium)
https://codereview.chromium.org/11787029/diff/1/chrome/browser/nacl_host/nacl_process_host.cc File chrome/browser/nacl_host/nacl_process_host.cc (right): https://codereview.chromium.org/11787029/diff/1/chrome/browser/nacl_host/nacl_process_host.cc#newcode131 chrome/browser/nacl_host/nacl_process_host.cc:131: std::vector<nacl::Handle> sockets_for_sel_ldr; On 2013/01/08 00:40:57, Mark Seaborn wrote: > ...
7 years, 11 months ago (2013-01-08 19:35:38 UTC) #3
Mark Seaborn
7 years, 11 months ago (2013-01-08 19:38:39 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698