Issue 11787015: Allow the password manager in the settings page to have hidpi favicons too

Issue 11787015: Allow the password manager in the settings page to have hidpi favicons too (Closed)

Created:
7 years, 11 months ago by pkotwicz

Modified:
7 years, 11 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Allow the password manager in the settings page to have hidpi favicons too. Changed FaviconSource such that 'size/xx@y/' can be prefixed to any type of chrome://favicon URL. Changed the scale factor to be a mandatory part of the size parameter to make the format of the chrome://favicon URLs less confusing Bug=168507 Test=Manual, see bug Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=178130

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 7

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : Rebased #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+144 lines, -62 lines)			Patch
M	chrome/browser/resources/ntp4/suggestions_page.js	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/ntp_android/ntp_android.js	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/options/password_manager_list.js	View	1 2	2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/resources/options/search_engine_manager_engine_list.js	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/suggestions_internals/suggestions_internals.js	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/favicon_source.h	View	1 2 3 4	2 chunks	+36 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/favicon_source.cc	View	1 2 3 4 5 6 7	5 chunks	+99 lines, -53 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

https://codereview.chromium.org/11787015/diff/2002/chrome/browser/ui/webui/favicon_source.cc File chrome/browser/ui/webui/favicon_source.cc (right): https://codereview.chromium.org/11787015/diff/2002/chrome/browser/ui/webui/favicon_source.cc#newcode53 chrome/browser/ui/webui/favicon_source.cc:53: size_t parsed_index = 0; can you add some docs ...

7 years, 11 months ago (2013-01-07 20:23:56 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/11787015/18008

7 years, 11 months ago (2013-01-22 20:17:45 UTC) #5

Message was sent while issue was closed.

Change committed as 178130

Expand Messages | Collapse Messages