Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 11787012: Encrypted Media: Add config change support in DecryptingAudioDecoder. (Closed)

Created:
7 years, 11 months ago by xhwang
Modified:
7 years, 11 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Encrypted Media: Add config change support in DecryptingAudioDecoder. BUG=168128, 168129 TEST=Added unittests; demo page works. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175300

Patch Set 1 #

Total comments: 4

Patch Set 2 : comments resolved #

Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -62 lines) Patch
M media/filters/decrypting_audio_decoder.h View 1 3 chunks +5 lines, -6 lines 0 comments Download
M media/filters/decrypting_audio_decoder.cc View 5 chunks +43 lines, -11 lines 0 comments Download
M media/filters/decrypting_audio_decoder_unittest.cc View 5 chunks +132 lines, -45 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
xhwang
This CL is a clone of the DVD change (11745026). PTAL!
7 years, 11 months ago (2013-01-05 01:14:13 UTC) #1
acolwell GONE FROM CHROMIUM
LGTM https://codereview.chromium.org/11787012/diff/1/media/filters/decrypting_audio_decoder.cc File media/filters/decrypting_audio_decoder.cc (right): https://codereview.chromium.org/11787012/diff/1/media/filters/decrypting_audio_decoder.cc#newcode293 media/filters/decrypting_audio_decoder.cc:293: decryptor_->InitializeAudioDecoder( same comment for this method as in ...
7 years, 11 months ago (2013-01-05 01:25:30 UTC) #2
xhwang
https://codereview.chromium.org/11787012/diff/1/media/filters/decrypting_audio_decoder.cc File media/filters/decrypting_audio_decoder.cc (right): https://codereview.chromium.org/11787012/diff/1/media/filters/decrypting_audio_decoder.cc#newcode293 media/filters/decrypting_audio_decoder.cc:293: decryptor_->InitializeAudioDecoder( On 2013/01/05 01:25:30, acolwell wrote: > same comment ...
7 years, 11 months ago (2013-01-05 04:09:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/11787012/5
7 years, 11 months ago (2013-01-06 05:06:18 UTC) #4
commit-bot: I haz the power
7 years, 11 months ago (2013-01-06 05:16:52 UTC) #5
Retried try job too often on ios_dbg_simulator for step(s) sync_unit_tests,
unit_tests

Powered by Google App Engine
This is Rietveld 408576698