Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(778)

Unified Diff: ui/base/dragdrop/drag_utils_win.cc

Issue 11787005: Get drag and drop working on Win Ash. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 7 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/base/dragdrop/drag_utils_aura.cc ('k') | ui/base/dragdrop/os_exchange_data.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/dragdrop/drag_utils_win.cc
===================================================================
--- ui/base/dragdrop/drag_utils_win.cc (revision 175112)
+++ ui/base/dragdrop/drag_utils_win.cc (working copy)
@@ -68,6 +68,12 @@
// Attach 'bitmap' to the data_object.
SetDragImageOnDataObject(bitmap, size, cursor_offset,
ui::OSExchangeDataProviderWin::GetIDataObject(*data_object));
+
+ // TODO: the above code is used in non-Ash, while below is used in Ash. If we
+ // could figure this context out then we wouldn't do unnecessary work. However
+ // as it stands getting this information in ui/base would be a layering
+ // violation.
jam 2013/01/04 22:23:02 Basically this code block is doing thw ork for bot
+ data_object->provider().SetDragImage(image_skia, cursor_offset);
}
} // namespace drag_utils
« no previous file with comments | « ui/base/dragdrop/drag_utils_aura.cc ('k') | ui/base/dragdrop/os_exchange_data.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698