Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 1178683009: Change histogram.h includes to histogram_macros.h in components/ (Closed)

Created:
5 years, 6 months ago by Alexei Svitkine (slow)
Modified:
5 years, 6 months ago
CC:
chromium-reviews, tim+watch_chromium.org, mlamouri+watch-content_chromium.org, zea+watch_chromium.org, pvalenzuela+watch_chromium.org, browser-components-watch_chromium.org, vabr+watchlist_chromium.org, maxbogue+watch_chromium.org, jam, plaree+watch_chromium.org, noyau+watch_chromium.org, darin-cc_chromium.org, tfarina, mkwst+moarreviews-renderer_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org, maniscalco+watch_chromium.org, markusheintz_, rouslan+autofillwatch_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change histogram.h includes to histogram_macros.h in components/ BUG=416479 Committed: https://crrev.com/a0f05db0971c18d51c646f457f72587323a88fef Cr-Commit-Position: refs/heads/master@{#334703}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -57 lines) Patch
M components/autofill/content/renderer/password_autofill_agent.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/autofill_external_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/autofill_metrics.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/personal_data_manager_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/common/password_generation_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/bookmarks/browser/bookmark_storage.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/content_settings/core/browser/content_settings_default_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/content_settings/core/browser/content_settings_pref.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/content_settings/core/browser/content_settings_pref_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_tamper_detection.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/dom_distiller/core/distiller_page.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/dom_distiller/core/feedback_reporter.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/dom_distiller/core/viewer.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/error_page/common/net_error_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/gcm_driver/gcm_driver_desktop.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/gcm_driver/gcm_stats_recorder_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/google/core/browser/google_search_metrics.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/history/core/browser/history_backend.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/history/core/browser/thumbnail_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/history/core/browser/top_sites_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/invalidation/gcm_network_channel.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/invalidation/ticl_invalidation_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/nacl/browser/nacl_browser.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/nacl/browser/nacl_process_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/omnibox/search_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/omnibox/search_suggestion_parser.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/core/browser/login_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/core/browser/password_form_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/core/browser/password_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/core/browser/password_manager_metrics_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/core/browser/password_store.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/core/browser/password_syncable_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/plugins/renderer/webview_plugin.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/browser/browser_policy_connector.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/cloud/cloud_policy_refresh_scheduler.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/cloud/cloud_policy_validator.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/cloud/user_cloud_policy_store.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/precache/core/precache_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/printing/renderer/print_web_view_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/search_engines/template_url_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/signin/core/browser/signin_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/storage_monitor/media_storage_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/suggestions/blacklist_store.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/suggestions/suggestions_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync_driver/data_type_manager_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync_driver/model_association_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/translate/content/renderer/translate_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/translate/core/browser/translate_browser_metrics.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/translate/core/browser/translate_infobar_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/translate/core/browser/translate_ui_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/translate/core/common/translate_metrics.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/web_cache/browser/web_cache_manager.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
Alexei Svitkine (slow)
isherman: review caitkp: components/ OWNERS review
5 years, 6 months ago (2015-06-15 21:34:49 UTC) #2
Ilya Sherman
LGTM % one thing: https://codereview.chromium.org/1178683009/diff/1/components/history/core/browser/top_sites_impl_unittest.cc File components/history/core/browser/top_sites_impl_unittest.cc (right): https://codereview.chromium.org/1178683009/diff/1/components/history/core/browser/top_sites_impl_unittest.cc#newcode11 components/history/core/browser/top_sites_impl_unittest.cc:11: #include "base/metrics/histogram_macros.h" Where is this ...
5 years, 6 months ago (2015-06-15 21:39:50 UTC) #3
Alexei Svitkine (slow)
Cait, PTAL? https://codereview.chromium.org/1178683009/diff/1/components/history/core/browser/top_sites_impl_unittest.cc File components/history/core/browser/top_sites_impl_unittest.cc (right): https://codereview.chromium.org/1178683009/diff/1/components/history/core/browser/top_sites_impl_unittest.cc#newcode11 components/history/core/browser/top_sites_impl_unittest.cc:11: #include "base/metrics/histogram_macros.h" On 2015/06/15 21:39:50, Ilya Sherman ...
5 years, 6 months ago (2015-06-16 15:18:36 UTC) #4
Cait (Slow)
lgtm
5 years, 6 months ago (2015-06-16 17:48:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1178683009/20001
5 years, 6 months ago (2015-06-16 17:52:30 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/70334)
5 years, 6 months ago (2015-06-16 20:37:41 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1178683009/20001
5 years, 6 months ago (2015-06-16 20:43:15 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-16 21:45:56 UTC) #13
commit-bot: I haz the power
5 years, 6 months ago (2015-06-16 21:46:45 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a0f05db0971c18d51c646f457f72587323a88fef
Cr-Commit-Position: refs/heads/master@{#334703}

Powered by Google App Engine
This is Rietveld 408576698