Issue 1178643008: Revert of Allow binding point to be specified on flow end events.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1178643008: Revert of Allow binding point to be specified on flow end events. (Closed)

Created:
5 years, 6 months ago by dsinclair

Modified:
5 years, 6 months ago

Reviewers:
benjhayden, Yufeng Shen (Slow to review), yuhaoz, nduca

CC:
chromium-reviews, erikwright+watch_chromium.org, jdduke+watch_chromium.org, tdresser+watch_chromium.org, tracing+reviews_chromium.org, wfh+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert of Allow binding point to be specified on flow end events. (patchset #2 id:20001 of https://codereview.chromium.org/1152553011/) Reason for revert: Conflict on the flag number used between this and ASYNC_TTS. Will cause very weird trace data. Original issue's description: > Allow binding point to be specified on flow end events. > > Committed: https://crrev.com/5e00a87e440d23e62082e8fc283d046fd05efa48 > Cr-Commit-Position: refs/heads/master@{#333797} TBR=benjhayden@chromium.org,miletus@chromium.org,nduca@chromium.org,yuhaoz@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/1004c0ca6cd74bb9b7b0cdd62fea5541a7aeaf1b Cr-Commit-Position: refs/heads/master@{#333958}

Patch Set 1 #

Created: 5 years, 6 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+1 line, -29 lines)			Patch
M	base/trace_event/trace_event.h	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	base/trace_event/trace_event_impl.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	base/trace_event/trace_event_unittest.cc	View	3 chunks	+0 lines, -21 lines	0 comments	Download
M	ui/events/latency_info.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

dsinclair

Created Revert of Allow binding point to be specified on flow end events.

5 years, 6 months ago (2015-06-11 15:33:41 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1178643008/1

5 years, 6 months ago (2015-06-11 15:35:03 UTC) #2

commit-bot: I haz the power

5 years, 6 months ago (2015-06-11 15:37:27 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/1004c0ca6cd74bb9b7b0cdd62fea5541a7aeaf1b
Cr-Commit-Position: refs/heads/master@{#333958}

Expand Messages | Collapse Messages