Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1075)

Unified Diff: Source/devtools/front_end/emulation/OverridesView.js

Issue 1178643004: [DevTools] Initial implementation of device modes. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Turn into class Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/emulation/OverridesView.js
diff --git a/Source/devtools/front_end/emulation/OverridesView.js b/Source/devtools/front_end/emulation/OverridesView.js
index b29651b09c4fe892c8ef3abcb6d9dace668fab49..5c03e705e0a2ae617aa668bff64af3f11407e5ab 100644
--- a/Source/devtools/front_end/emulation/OverridesView.js
+++ b/Source/devtools/front_end/emulation/OverridesView.js
@@ -199,7 +199,10 @@ WebInspector.OverridesView.DeviceTab.prototype = {
var deviceModelElement = fieldsetElement.createChild("p", "overrides-device-model-section");
deviceModelElement.createChild("span").textContent = WebInspector.UIString("Model:");
- deviceModelElement.appendChild(WebInspector.OverridesUI.createDeviceSelect());
+ var rotateButton = createElement("button");
+ rotateButton.textContent = " \u21C4 ";
+ var deviceSelect = new WebInspector.DeviceSelect(rotateButton);
+ deviceModelElement.appendChild(deviceSelect.element);
var emulateResolutionCheckbox = WebInspector.SettingsUI.createSettingCheckbox(WebInspector.UIString("Emulate screen resolution"), WebInspector.overridesSupport.settings.emulateResolution, true);
fieldsetElement.appendChild(emulateResolutionCheckbox);
@@ -214,11 +217,6 @@ WebInspector.OverridesView.DeviceTab.prototype = {
var widthOverrideInput = WebInspector.SettingsUI.createSettingInputField("", WebInspector.overridesSupport.settings.deviceWidth, true, 4, "80px", WebInspector.OverridesSupport.deviceSizeValidator, true, true, WebInspector.UIString("\u2013"));
cellElement.appendChild(widthOverrideInput);
- this._swapDimensionsElement = cellElement.createChild("button", "overrides-swap");
- this._swapDimensionsElement.createTextChild(" \u21C4 "); // RIGHTWARDS ARROW OVER LEFTWARDS ARROW.
- this._swapDimensionsElement.title = WebInspector.UIString("Swap dimensions");
- this._swapDimensionsElement.addEventListener("click", WebInspector.overridesSupport.swapDimensions.bind(WebInspector.overridesSupport), false);
- this._swapDimensionsElement.tabIndex = -1;
var heightOverrideInput = WebInspector.SettingsUI.createSettingInputField("", WebInspector.overridesSupport.settings.deviceHeight, true, 4, "80px", WebInspector.OverridesSupport.deviceSizeValidator, true, true, WebInspector.UIString("\u2013"));
cellElement.appendChild(heightOverrideInput);
« no previous file with comments | « Source/devtools/front_end/emulation/OverridesUI.js ('k') | Source/devtools/front_end/emulation/ResponsiveDesignView.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698