Source/devtools/front_end/emulation/OverridesView.js - Issue 1178643004: [DevTools] Initial implementation of device modes.

Unified Diff: Source/devtools/front_end/emulation/OverridesView.js

Issue 1178643004: [DevTools] Initial implementation of device modes. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fixed review comments Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/devtools/front_end/emulation/OverridesUI.js ('K') | « Source/devtools/front_end/emulation/OverridesUI.js ('k') | Source/devtools/front_end/emulation/ResponsiveDesignView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/devtools/front_end/emulation/OverridesView.js

diff --git a/Source/devtools/front_end/emulation/OverridesView.js b/Source/devtools/front_end/emulation/OverridesView.js

index c2ab9527906684e0674c52c11563873c419c3700..599f79936fcb590215648d41edcd978c4ff8f597 100644

--- a/Source/devtools/front_end/emulation/OverridesView.js

+++ b/Source/devtools/front_end/emulation/OverridesView.js

@@ -38,6 +38,8 @@ WebInspector.OverridesView = function()

this.setMinimumSize(0, 30);

this.registerRequiredCSS("emulation/overrides.css");

this.element.classList.add("overrides-view");

+ if (Runtime.experiments.isEnabled("deviceModes"))

+ this.element.classList.add("device-modes");

this._tabbedPane = new WebInspector.TabbedPane();

this._tabbedPane.setShrinkableTabs(false);

@@ -199,7 +201,7 @@ WebInspector.OverridesView.DeviceTab.prototype = {

var deviceModelElement = fieldsetElement.createChild("p", "overrides-device-model-section");

deviceModelElement.createChild("span").textContent = WebInspector.UIString("Model:");

- deviceModelElement.appendChild(WebInspector.OverridesUI.createDeviceSelect());

+ deviceModelElement.appendChild(WebInspector.OverridesUI.createDeviceSelect(""));

var emulateResolutionCheckbox = WebInspector.SettingsUI.createSettingCheckbox(WebInspector.UIString("Emulate screen resolution"), WebInspector.overridesSupport.settings.emulateResolution, true);

fieldsetElement.appendChild(emulateResolutionCheckbox);

@@ -214,11 +216,13 @@ WebInspector.OverridesView.DeviceTab.prototype = {

var widthOverrideInput = WebInspector.SettingsUI.createSettingInputField("", WebInspector.overridesSupport.settings.deviceWidth, true, 4, "80px", WebInspector.OverridesSupport.deviceSizeValidator, true, true, WebInspector.UIString("\u2013"));

cellElement.appendChild(widthOverrideInput);

- this._swapDimensionsElement = cellElement.createChild("button", "overrides-swap");

- this._swapDimensionsElement.createTextChild(" \u21C4 "); // RIGHTWARDS ARROW OVER LEFTWARDS ARROW.

- this._swapDimensionsElement.title = WebInspector.UIString("Swap dimensions");

- this._swapDimensionsElement.addEventListener("click", WebInspector.overridesSupport.swapDimensions.bind(WebInspector.overridesSupport), false);

- this._swapDimensionsElement.tabIndex = -1;

+ if (!Runtime.experiments.isEnabled("deviceModes")) {

+ var swapDimensionsElement = cellElement.createChild("button", "overrides-swap");

+ swapDimensionsElement.createTextChild(" \u21C4 "); // RIGHTWARDS ARROW OVER LEFTWARDS ARROW.

+ swapDimensionsElement.title = WebInspector.UIString("Swap dimensions");

+ swapDimensionsElement.addEventListener("click", WebInspector.overridesSupport.swapDimensions.bind(WebInspector.overridesSupport), false);

+ swapDimensionsElement.tabIndex = -1;

+ }

var heightOverrideInput = WebInspector.SettingsUI.createSettingInputField("", WebInspector.overridesSupport.settings.deviceHeight, true, 4, "80px", WebInspector.OverridesSupport.deviceSizeValidator, true, true, WebInspector.UIString("\u2013"));

cellElement.appendChild(heightOverrideInput);