Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Side by Side Diff: Source/devtools/front_end/emulation/OverridesView.js

Issue 1178643004: [DevTools] Initial implementation of device modes. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fixed review comments Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2014 Google Inc. All rights reserved. 2 * Copyright (C) 2014 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 20 matching lines...) Expand all
31 /** 31 /**
32 * @constructor 32 * @constructor
33 * @extends {WebInspector.VBox} 33 * @extends {WebInspector.VBox}
34 */ 34 */
35 WebInspector.OverridesView = function() 35 WebInspector.OverridesView = function()
36 { 36 {
37 WebInspector.VBox.call(this); 37 WebInspector.VBox.call(this);
38 this.setMinimumSize(0, 30); 38 this.setMinimumSize(0, 30);
39 this.registerRequiredCSS("emulation/overrides.css"); 39 this.registerRequiredCSS("emulation/overrides.css");
40 this.element.classList.add("overrides-view"); 40 this.element.classList.add("overrides-view");
41 if (Runtime.experiments.isEnabled("deviceModes"))
42 this.element.classList.add("device-modes");
41 43
42 this._tabbedPane = new WebInspector.TabbedPane(); 44 this._tabbedPane = new WebInspector.TabbedPane();
43 this._tabbedPane.setShrinkableTabs(false); 45 this._tabbedPane.setShrinkableTabs(false);
44 this._tabbedPane.setVerticalTabLayout(true); 46 this._tabbedPane.setVerticalTabLayout(true);
45 47
46 new WebInspector.OverridesView.DeviceTab().appendAsTab(this._tabbedPane); 48 new WebInspector.OverridesView.DeviceTab().appendAsTab(this._tabbedPane);
47 new WebInspector.OverridesView.MediaTab().appendAsTab(this._tabbedPane); 49 new WebInspector.OverridesView.MediaTab().appendAsTab(this._tabbedPane);
48 new WebInspector.OverridesView.NetworkTab().appendAsTab(this._tabbedPane); 50 new WebInspector.OverridesView.NetworkTab().appendAsTab(this._tabbedPane);
49 new WebInspector.OverridesView.SensorsTab().appendAsTab(this._tabbedPane); 51 new WebInspector.OverridesView.SensorsTab().appendAsTab(this._tabbedPane);
50 52
(...skipping 141 matching lines...) Expand 10 before | Expand all | Expand 10 after
192 194
193 WebInspector.OverridesView.DeviceTab.prototype = { 195 WebInspector.OverridesView.DeviceTab.prototype = {
194 _createDeviceElement: function() 196 _createDeviceElement: function()
195 { 197 {
196 var fieldsetElement = createElement("fieldset"); 198 var fieldsetElement = createElement("fieldset");
197 fieldsetElement.id = "metrics-override-section"; 199 fieldsetElement.id = "metrics-override-section";
198 200
199 var deviceModelElement = fieldsetElement.createChild("p", "overrides-dev ice-model-section"); 201 var deviceModelElement = fieldsetElement.createChild("p", "overrides-dev ice-model-section");
200 deviceModelElement.createChild("span").textContent = WebInspector.UIStri ng("Model:"); 202 deviceModelElement.createChild("span").textContent = WebInspector.UIStri ng("Model:");
201 203
202 deviceModelElement.appendChild(WebInspector.OverridesUI.createDeviceSele ct()); 204 deviceModelElement.appendChild(WebInspector.OverridesUI.createDeviceSele ct(""));
203 205
204 var emulateResolutionCheckbox = WebInspector.SettingsUI.createSettingChe ckbox(WebInspector.UIString("Emulate screen resolution"), WebInspector.overrides Support.settings.emulateResolution, true); 206 var emulateResolutionCheckbox = WebInspector.SettingsUI.createSettingChe ckbox(WebInspector.UIString("Emulate screen resolution"), WebInspector.overrides Support.settings.emulateResolution, true);
205 fieldsetElement.appendChild(emulateResolutionCheckbox); 207 fieldsetElement.appendChild(emulateResolutionCheckbox);
206 var resolutionFieldset = WebInspector.SettingsUI.createSettingFieldset(W ebInspector.overridesSupport.settings.emulateResolution); 208 var resolutionFieldset = WebInspector.SettingsUI.createSettingFieldset(W ebInspector.overridesSupport.settings.emulateResolution);
207 fieldsetElement.appendChild(resolutionFieldset); 209 fieldsetElement.appendChild(resolutionFieldset);
208 210
209 var tableElement = resolutionFieldset.createChild("table"); 211 var tableElement = resolutionFieldset.createChild("table");
210 var rowElement = tableElement.createChild("tr"); 212 var rowElement = tableElement.createChild("tr");
211 var cellElement = rowElement.createChild("td"); 213 var cellElement = rowElement.createChild("td");
212 cellElement.createTextChild(WebInspector.UIString("Resolution:")); 214 cellElement.createTextChild(WebInspector.UIString("Resolution:"));
213 cellElement = rowElement.createChild("td"); 215 cellElement = rowElement.createChild("td");
214 216
215 var widthOverrideInput = WebInspector.SettingsUI.createSettingInputField ("", WebInspector.overridesSupport.settings.deviceWidth, true, 4, "80px", WebIns pector.OverridesSupport.deviceSizeValidator, true, true, WebInspector.UIString(" \u2013")); 217 var widthOverrideInput = WebInspector.SettingsUI.createSettingInputField ("", WebInspector.overridesSupport.settings.deviceWidth, true, 4, "80px", WebIns pector.OverridesSupport.deviceSizeValidator, true, true, WebInspector.UIString(" \u2013"));
216 cellElement.appendChild(widthOverrideInput); 218 cellElement.appendChild(widthOverrideInput);
217 this._swapDimensionsElement = cellElement.createChild("button", "overrid es-swap"); 219 if (!Runtime.experiments.isEnabled("deviceModes")) {
218 this._swapDimensionsElement.createTextChild(" \u21C4 "); // RIGHTWARDS A RROW OVER LEFTWARDS ARROW. 220 var swapDimensionsElement = cellElement.createChild("button", "overr ides-swap");
219 this._swapDimensionsElement.title = WebInspector.UIString("Swap dimensio ns"); 221 swapDimensionsElement.createTextChild(" \u21C4 "); // RIGHTWARDS ARR OW OVER LEFTWARDS ARROW.
220 this._swapDimensionsElement.addEventListener("click", WebInspector.overr idesSupport.swapDimensions.bind(WebInspector.overridesSupport), false); 222 swapDimensionsElement.title = WebInspector.UIString("Swap dimensions ");
221 this._swapDimensionsElement.tabIndex = -1; 223 swapDimensionsElement.addEventListener("click", WebInspector.overrid esSupport.swapDimensions.bind(WebInspector.overridesSupport), false);
224 swapDimensionsElement.tabIndex = -1;
225 }
222 var heightOverrideInput = WebInspector.SettingsUI.createSettingInputFiel d("", WebInspector.overridesSupport.settings.deviceHeight, true, 4, "80px", WebI nspector.OverridesSupport.deviceSizeValidator, true, true, WebInspector.UIString ("\u2013")); 226 var heightOverrideInput = WebInspector.SettingsUI.createSettingInputFiel d("", WebInspector.overridesSupport.settings.deviceHeight, true, 4, "80px", WebI nspector.OverridesSupport.deviceSizeValidator, true, true, WebInspector.UIString ("\u2013"));
223 cellElement.appendChild(heightOverrideInput); 227 cellElement.appendChild(heightOverrideInput);
224 228
225 rowElement = tableElement.createChild("tr"); 229 rowElement = tableElement.createChild("tr");
226 cellElement = rowElement.createChild("td"); 230 cellElement = rowElement.createChild("td");
227 cellElement.colSpan = 4; 231 cellElement.colSpan = 4;
228 232
229 rowElement = tableElement.createChild("tr"); 233 rowElement = tableElement.createChild("tr");
230 rowElement.title = WebInspector.UIString("Ratio between a device's physi cal pixels and device-independent pixels."); 234 rowElement.title = WebInspector.UIString("Ratio between a device's physi cal pixels and device-independent pixels.");
231 rowElement.createChild("td").createTextChild(WebInspector.UIString("Devi ce pixel ratio:")); 235 rowElement.createChild("td").createTextChild(WebInspector.UIString("Devi ce pixel ratio:"));
(...skipping 404 matching lines...) Expand 10 before | Expand all | Expand 10 after
636 * @override 640 * @override
637 * @param {!Object} overridesSupport 641 * @param {!Object} overridesSupport
638 * @return {!Promise} 642 * @return {!Promise}
639 */ 643 */
640 reveal: function(overridesSupport) 644 reveal: function(overridesSupport)
641 { 645 {
642 WebInspector.inspectorView.showViewInDrawer("emulation"); 646 WebInspector.inspectorView.showViewInDrawer("emulation");
643 return Promise.resolve(); 647 return Promise.resolve();
644 } 648 }
645 } 649 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698