Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1035)

Issue 1178623002: Remove _emptyList from fn2.dart (Closed)

Created:
5 years, 6 months ago by abarth-chromium
Modified:
5 years, 6 months ago
Reviewers:
Hixie
CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove _emptyList from fn2.dart We can use const [] instead and we'll be sure we don't mutate this constant. R=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/a5ffe7d9c247c41f9609c038e87310567d866194

Patch Set 1 #

Total comments: 1

Patch Set 2 : style fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -8 lines) Patch
M sky/sdk/lib/framework/fn2.dart View 1 2 chunks +2 lines, -6 lines 0 comments Download
M sky/specs/style-guide.md View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 6 months ago (2015-06-10 19:38:18 UTC) #1
Hixie
lgtm https://codereview.chromium.org/1178623002/diff/1/sky/sdk/lib/framework/fn2.dart File sky/sdk/lib/framework/fn2.dart (right): https://codereview.chromium.org/1178623002/diff/1/sky/sdk/lib/framework/fn2.dart#newcode541 sky/sdk/lib/framework/fn2.dart:541: }) : this.children = children == null ? ...
5 years, 6 months ago (2015-06-10 19:39:17 UTC) #2
abarth-chromium
5 years, 6 months ago (2015-06-10 19:42:45 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
a5ffe7d9c247c41f9609c038e87310567d866194 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698