Issue 1178623002: Remove _emptyList from fn2.dart

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1178623002: Remove _emptyList from fn2.dart (Closed)

Created:
5 years, 6 months ago by abarth-chromium

Modified:
5 years, 6 months ago

Reviewers:
Hixie

CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Remove _emptyList from fn2.dart We can use const [] instead and we'll be sure we don't mutate this constant. R=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/a5ffe7d9c247c41f9609c038e87310567d866194

Patch Set 2 : style fix #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -8 lines)			Patch
	M	sky/sdk/lib/framework/fn2.dart	View	1	2 chunks	+2 lines, -6 lines	0 comments	Download
	M	sky/specs/style-guide.md	View	1	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Hixie

lgtm https://codereview.chromium.org/1178623002/diff/1/sky/sdk/lib/framework/fn2.dart File sky/sdk/lib/framework/fn2.dart (right): https://codereview.chromium.org/1178623002/diff/1/sky/sdk/lib/framework/fn2.dart#newcode541 sky/sdk/lib/framework/fn2.dart:541: }) : this.children = children == null ? ...

5 years, 6 months ago (2015-06-10 19:39:17 UTC) #2

abarth-chromium

5 years, 6 months ago (2015-06-10 19:42:45 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
a5ffe7d9c247c41f9609c038e87310567d866194 (presubmit successful).

Expand Messages | Collapse Messages

Issue 1178623002: Remove _emptyList from fn2.dart (Closed)

Description

Patch Set 1 #

Patch Set 2 : style fix #

Messages