Issue 11786006: Added flags to override hosts for LSO URLs.

Issue 11786006: Added flags to override hosts for LSO URLs. (Closed)

Created:
7 years, 11 months ago by zel

Modified:
7 years, 11 months ago

Reviewers:
xiyuan, Bin, Ryan Sleevi, Joao da Silva

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Added --lso-host switch that lets us override hosts for LSO URLs. BUG=168602 TEST=existing unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175900

Patch Set 5 : #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+81 lines, -36 lines)			Patch
M	chrome/browser/resources/gaia_auth/manifest_test.json	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	google_apis/gaia/gaia_switches.h	View		2 chunks	+14 lines, -1 line	0 comments	Download
M	google_apis/gaia/gaia_switches.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	google_apis/gaia/gaia_urls.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	google_apis/gaia/gaia_urls.cc	View	1 2	3 chunks	+53 lines, -34 lines	0 comments	Download
M	net/url_request/url_fetcher_core.h	View	1 2 3	1 chunk	+3 lines, -0 lines	0 comments	Download
M	net/url_request/url_fetcher_core.cc	View	1 2 3 4	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

xiyuan

LGTM https://codereview.chromium.org/11786006/diff/1/google_apis/gaia/gaia_urls.cc File google_apis/gaia/gaia_urls.cc (right): https://codereview.chromium.org/11786006/diff/1/google_apis/gaia/gaia_urls.cc#newcode70 google_apis/gaia/gaia_urls.cc:70: GetSwitchValueWithDefault(switches::kGoogleApisHost, kDefaultGoogleApisBaseUrl, nit: 80 cols

7 years, 11 months ago (2013-01-07 23:16:46 UTC) #3

zel

https://codereview.chromium.org/11786006/diff/1/google_apis/gaia/gaia_urls.cc File google_apis/gaia/gaia_urls.cc (right): https://codereview.chromium.org/11786006/diff/1/google_apis/gaia/gaia_urls.cc#newcode70 google_apis/gaia/gaia_urls.cc:70: GetSwitchValueWithDefault(switches::kGoogleApisHost, kDefaultGoogleApisBaseUrl, On 2013/01/07 23:16:46, xiyuan wrote: > nit: ...

7 years, 11 months ago (2013-01-08 01:13:08 UTC) #4

Joao da Silva

LGTM. Please consider the comment inline about the scope URL. https://codereview.chromium.org/11786006/diff/6001/google_apis/gaia/gaia_urls.cc File google_apis/gaia/gaia_urls.cc (right): https://codereview.chromium.org/11786006/diff/6001/google_apis/gaia/gaia_urls.cc#newcode25 ...

7 years, 11 months ago (2013-01-08 09:16:50 UTC) #5

zel

https://codereview.chromium.org/11786006/diff/6001/google_apis/gaia/gaia_urls.cc File google_apis/gaia/gaia_urls.cc (right): https://codereview.chromium.org/11786006/diff/6001/google_apis/gaia/gaia_urls.cc#newcode25 google_apis/gaia/gaia_urls.cc:25: const char kOAuth1LoginScopeSuffix[] = "/OAuthLogin"; On 2013/01/08 09:16:50, Joao ...

7 years, 11 months ago (2013-01-08 22:00:36 UTC) #6

Ryan Sleevi

net/ LGTM https://codereview.chromium.org/11786006/diff/24002/net/url_request/url_fetcher_core.cc File net/url_request/url_fetcher_core.cc (right): https://codereview.chromium.org/11786006/diff/24002/net/url_request/url_fetcher_core.cc#newcode626 net/url_request/url_fetcher_core.cc:626: SSLCertRequestInfo* cert_request_info) { style nit: wrapping should ...

7 years, 11 months ago (2013-01-09 21:45:53 UTC) #8

zel

7 years, 11 months ago (2013-01-09 23:10:37 UTC) #9

Message was sent while issue was closed.

https://codereview.chromium.org/11786006/diff/24002/net/url_request/url_fetch...
File net/url_request/url_fetcher_core.cc (right):

https://codereview.chromium.org/11786006/diff/24002/net/url_request/url_fetch...
net/url_request/url_fetcher_core.cc:626: SSLCertRequestInfo* cert_request_info)
{
On 2013/01/09 21:45:54, Ryan Sleevi wrote:
> style nit: wrapping should have URLRequest* on a new line

Done.

Expand Messages | Collapse Messages