Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 1178573002: Extend relocation packing to non-ARM architectures. (Closed)

Created:
5 years, 6 months ago by simonb (inactive)
Modified:
5 years, 6 months ago
Reviewers:
Nico, rmcilroy
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Extend relocation packing to non-ARM architectures. Apply relocation packing to ia32 and mips32 builds. Deferred for x64 pending migration of an ndk bug fix into the chromium tree. See b/20532404. BUG=385553 Committed: https://crrev.com/00ad6ff02565ee933f61b08c7f38723a307d7902 Cr-Commit-Position: refs/heads/master@{#335921}

Patch Set 1 #

Patch Set 2 : Rebase to master. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -202 lines) Patch
M build/all.gyp View 1 1 chunk +2 lines, -2 lines 0 comments Download
D build/android/gyp/pack_arm_relocations.py View 1 chunk +0 lines, -107 lines 0 comments Download
A + build/android/gyp/pack_relocations.py View 0 chunks +-1 lines, --1 lines 0 comments Download
D build/android/pack_arm_relocations.gypi View 1 chunk +0 lines, -77 lines 0 comments Download
A + build/android/pack_relocations.gypi View 5 chunks +5 lines, -5 lines 0 comments Download
M build/android/push_libraries.gypi View 1 chunk +1 line, -1 line 0 comments Download
M build/config/android/rules.gni View 1 1 chunk +1 line, -1 line 0 comments Download
M build/java_apk.gypi View 1 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/android/chrome_apk.gypi View 1 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
simonb (inactive)
[ +cjhopmap@ for build OWNERS review. ]
5 years, 6 months ago (2015-06-10 14:36:50 UTC) #2
rmcilroy
lgtm, thanks! Any ETA on the NDK roll which will include the fix for b/20532404 ...
5 years, 6 months ago (2015-06-10 14:50:52 UTC) #3
simonb (inactive)
On 2015/06/10 14:50:52, rmcilroy wrote: > lgtm, thanks! > > Any ETA on the NDK ...
5 years, 6 months ago (2015-06-10 15:23:12 UTC) #4
simonb (inactive)
-cjhopman +thakis for build/OWNERS review
5 years, 6 months ago (2015-06-16 18:18:18 UTC) #6
Nico
lgtm
5 years, 6 months ago (2015-06-16 18:23:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1178573002/20001
5 years, 6 months ago (2015-06-24 13:43:03 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-24 14:46:19 UTC) #11
commit-bot: I haz the power
5 years, 6 months ago (2015-06-24 14:47:08 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/00ad6ff02565ee933f61b08c7f38723a307d7902
Cr-Commit-Position: refs/heads/master@{#335921}

Powered by Google App Engine
This is Rietveld 408576698