Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1714)

Unified Diff: Source/devtools/front_end/network/NetworkLogView.js

Issue 1178563002: DevTools: Refactor network panel overview (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: update test. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/devtools.gypi ('k') | Source/devtools/front_end/network/NetworkOverview.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/network/NetworkLogView.js
diff --git a/Source/devtools/front_end/network/NetworkLogView.js b/Source/devtools/front_end/network/NetworkLogView.js
index 784a805b506209e31630db8f01ec742eed2917a2..6140c0a17d0e928d3da67226a5e447abe455ab3a 100644
--- a/Source/devtools/front_end/network/NetworkLogView.js
+++ b/Source/devtools/front_end/network/NetworkLogView.js
@@ -33,12 +33,11 @@
* @implements {WebInspector.Searchable}
* @implements {WebInspector.TargetManager.Observer}
* @extends {WebInspector.VBox}
- * @param {!WebInspector.NetworkOverview} overview
* @param {!WebInspector.FilterBar} filterBar
* @param {!Element} progressBarContainer
* @param {!WebInspector.Setting} networkLogLargeRowsSetting
*/
-WebInspector.NetworkLogView = function(overview, filterBar, progressBarContainer, networkLogLargeRowsSetting)
+WebInspector.NetworkLogView = function(filterBar, progressBarContainer, networkLogLargeRowsSetting)
{
WebInspector.VBox.call(this);
this.registerRequiredCSS("network/networkLogView.css");
@@ -49,8 +48,6 @@ WebInspector.NetworkLogView = function(overview, filterBar, progressBarContainer
this._networkShowPrimaryLoadWaterfallSetting = WebInspector.settings.createSetting("networkShowPrimaryLoadWaterfall", false);
this._filterBar = filterBar;
- /** @type {!WebInspector.NetworkOverview} */
- this._overview = overview;
this._progressBarContainer = progressBarContainer;
this._networkLogLargeRowsSetting = networkLogLargeRowsSetting;
@@ -99,8 +96,6 @@ WebInspector.NetworkLogView = function(overview, filterBar, progressBarContainer
this._resetSuggestionBuilder();
this._initializeView();
- this._overview.addEventListener(WebInspector.NetworkOverview.Events.WindowChanged, this._onWindowChanged, this);
-
WebInspector.moduleSetting("networkColorCodeResourceTypes").addChangeListener(this._invalidateAllItems, this);
this._networkLogLargeRowsSetting.addChangeListener(this._updateRowsSize, this);
@@ -216,12 +211,11 @@ WebInspector.NetworkLogView.prototype = {
},
/**
- * @param {!WebInspector.Event} event
+ * @param {number} start
+ * @param {number} end
*/
- _onWindowChanged: function(event)
+ setWindow: function(start, end)
{
- var start = /** @type {number} */ (event.data.start);
- var end = /** @type {number} */ (event.data.end);
if (!start && !end) {
this._timeFilter = null;
this._timeCalculator.setWindow(null);
@@ -945,7 +939,6 @@ WebInspector.NetworkLogView.prototype = {
if (this._popoverHelper)
this._popoverHelper.hidePopover();
- this._overview.reset();
this._timeFilter = null;
this._calculator.reset();
@@ -1042,7 +1035,7 @@ WebInspector.NetworkLogView.prototype = {
}
this._staleRequestIds[request.requestId] = true;
- this._overview.updateRequest(request);
+ this.dispatchEventToListeners(WebInspector.NetworkLogView.EventTypes.UpdateRequest, request);
this._scheduleRefresh();
},
@@ -2032,5 +2025,6 @@ WebInspector.NetworkLogView._requestTimeFilter = function(windowStart, windowEnd
WebInspector.NetworkLogView.EventTypes = {
RequestSelected: "RequestSelected",
SearchCountUpdated: "SearchCountUpdated",
- SearchIndexUpdated: "SearchIndexUpdated"
+ SearchIndexUpdated: "SearchIndexUpdated",
+ UpdateRequest: "UpdateRequest"
};
« no previous file with comments | « Source/devtools/devtools.gypi ('k') | Source/devtools/front_end/network/NetworkOverview.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698