DevTools: Refactor network panel overview

DevTools: Refactor network panel overview

Make it use TimelineOverviewPane, so NetworkOverview now implements
TimelineOverview interface.
The TimelineOverview* classes are moved to ui_lazy.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196966

[alph, 2015-06-10 14:26:29]

alph@chromium.org changed reviewers:
+ pfeldman@chromium.org, yurys@chromium.org

[alph, 2015-06-10 14:26:30]

ptal

[yurys, 2015-06-11 15:33:37]

lgtm

https://codereview.chromium.org/1178563002/diff/1/Source/devtools/front_end/n...
File Source/devtools/front_end/network/NetworkLogView.js (right):

https://codereview.chromium.org/1178563002/diff/1/Source/devtools/front_end/n...
Source/devtools/front_end/network/NetworkLogView.js:2026: RequestSelected:
Symbol("RequestSelected"),
Although I agree that Symbols would be more appropriate for event name
constants, we don't use them in the rest of the codebase and I'd rather we stuck
with the one and the same style everywhere.

https://codereview.chromium.org/1178563002/diff/1/Source/devtools/front_end/n...
File Source/devtools/front_end/network/NetworkTimeCalculator.js (right):

https://codereview.chromium.org/1178563002/diff/1/Source/devtools/front_end/n...
Source/devtools/front_end/network/NetworkTimeCalculator.js:323:
_updateBoundariesWithTimestamp: function(timestamp)
_extendBoundariesToIncludeTimestamp

https://codereview.chromium.org/1178563002/diff/1/Source/devtools/front_end/n...
Source/devtools/front_end/network/NetworkTimeCalculator.js:332:
this._boundaryChanged();
This call can be done once in updateBoundaries.

https://codereview.chromium.org/1178563002/diff/1/Source/devtools/front_end/u...
File Source/devtools/front_end/ui_lazy/TimelineGrid.js (right):

https://codereview.chromium.org/1178563002/diff/1/Source/devtools/front_end/u...
Source/devtools/front_end/ui_lazy/TimelineGrid.js:42:
this._gridHeaderElement.classList.add("timeline-grid-header");
There is no such class in css, consider removing this line.

https://codereview.chromium.org/1178563002/diff/1/Source/devtools/front_end/u...
File Source/devtools/front_end/ui_lazy/TimelineOverviewPane.js (right):

https://codereview.chromium.org/1178563002/diff/1/Source/devtools/front_end/u...
Source/devtools/front_end/ui_lazy/TimelineOverviewPane.js:53: WindowChanged:
Symbol("WindowChanged")
If you allow to use Symbols for event names, you should update
WebInspector.Object.prototype.*Listener* method annotations. Would be nice to
have all of that in a separate CL.

https://codereview.chromium.org/1178563002/diff/1/Source/devtools/front_end/u...
Source/devtools/front_end/ui_lazy/TimelineOverviewPane.js:430: var absoluteMin =
this._calculator.minimumBoundary();
Do we need this code in base?

[alph, 2015-06-11 16:35:00]

https://codereview.chromium.org/1178563002/diff/1/Source/devtools/front_end/n...
File Source/devtools/front_end/network/NetworkLogView.js (right):

https://codereview.chromium.org/1178563002/diff/1/Source/devtools/front_end/n...
Source/devtools/front_end/network/NetworkLogView.js:2026: RequestSelected:
Symbol("RequestSelected"),
On 2015/06/11 15:33:36, yurys wrote:
> Although I agree that Symbols would be more appropriate for event name
> constants, we don't use them in the rest of the codebase and I'd rather we
stuck
> with the one and the same style everywhere.

Reverted.

https://codereview.chromium.org/1178563002/diff/1/Source/devtools/front_end/n...
File Source/devtools/front_end/network/NetworkTimeCalculator.js (right):

https://codereview.chromium.org/1178563002/diff/1/Source/devtools/front_end/n...
Source/devtools/front_end/network/NetworkTimeCalculator.js:323:
_updateBoundariesWithTimestamp: function(timestamp)
On 2015/06/11 15:33:36, yurys wrote:
> _extendBoundariesToIncludeTimestamp

Done.

https://codereview.chromium.org/1178563002/diff/1/Source/devtools/front_end/n...
Source/devtools/front_end/network/NetworkTimeCalculator.js:332:
this._boundaryChanged();
On 2015/06/11 15:33:36, yurys wrote:
> This call can be done once in updateBoundaries.

Done.

https://codereview.chromium.org/1178563002/diff/1/Source/devtools/front_end/u...
File Source/devtools/front_end/ui_lazy/TimelineGrid.js (right):

https://codereview.chromium.org/1178563002/diff/1/Source/devtools/front_end/u...
Source/devtools/front_end/ui_lazy/TimelineGrid.js:42:
this._gridHeaderElement.classList.add("timeline-grid-header");
On 2015/06/11 15:33:36, yurys wrote:
> There is no such class in css, consider removing this line.

It's in timelineGrid.css

https://codereview.chromium.org/1178563002/diff/1/Source/devtools/front_end/u...
File Source/devtools/front_end/ui_lazy/TimelineOverviewPane.js (right):

https://codereview.chromium.org/1178563002/diff/1/Source/devtools/front_end/u...
Source/devtools/front_end/ui_lazy/TimelineOverviewPane.js:53: WindowChanged:
Symbol("WindowChanged")
On 2015/06/11 15:33:36, yurys wrote:
> If you allow to use Symbols for event names, you should update
> WebInspector.Object.prototype.*Listener* method annotations. Would be nice to
> have all of that in a separate CL.

Acknowledged.

https://codereview.chromium.org/1178563002/diff/1/Source/devtools/front_end/u...
Source/devtools/front_end/ui_lazy/TimelineOverviewPane.js:430: var absoluteMin =
this._calculator.minimumBoundary();
On 2015/06/11 15:33:36, yurys wrote:
> Do we need this code in base?

I'd like to have a default implementation in base.

[alph, 2015-06-11 17:04:19]

The CQ bit was checked by alph@chromium.org

[alph, 2015-06-11 17:04:20]

The patchset sent to the CQ was uploaded after l-g-t-m from yurys@chromium.org
Link to the patchset: https://codereview.chromium.org/1178563002/#ps40001
(title: "update test.")

[commit-bot: I haz the power, 2015-06-11 17:04:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1178563002/40001

[commit-bot: I haz the power, 2015-06-11 18:33:10]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196966