Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(45)

Issue 1178563002: DevTools: Refactor network panel overview (Closed)

Created:
4 years, 10 months ago by alph
Modified:
4 years, 10 months ago
Reviewers:
pfeldman, yurys
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: Refactor network panel overview Make it use TimelineOverviewPane, so NetworkOverview now implements TimelineOverview interface. The TimelineOverview* classes are moved to ui_lazy. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196966

Patch Set 1 #

Total comments: 12

Patch Set 2 : addressing comments. #

Patch Set 3 : update test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+241 lines, -734 lines) Patch
M LayoutTests/inspector/tracing/timeline-window-filter.html View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/devtools.gypi View 1 2 chunks +1 line, -1 line 0 comments Download
M Source/devtools/front_end/network/NetworkLogView.js View 1 7 chunks +7 lines, -13 lines 0 comments Download
M Source/devtools/front_end/network/NetworkOverview.js View 13 chunks +31 lines, -100 lines 0 comments Download
M Source/devtools/front_end/network/NetworkPanel.js View 1 12 chunks +49 lines, -13 lines 0 comments Download
M Source/devtools/front_end/network/NetworkTimeCalculator.js View 1 1 chunk +24 lines, -13 lines 0 comments Download
M Source/devtools/front_end/network/networkPanel.css View 1 1 chunk +8 lines, -16 lines 0 comments Download
M Source/devtools/front_end/timeline/CountersGraph.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/timeline/TimelineEventOverview.js View 2 chunks +35 lines, -1 line 0 comments Download
M Source/devtools/front_end/timeline/TimelineFrameOverview.js View 1 4 chunks +12 lines, -6 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineMemoryOverview.js View 1 chunk +2 lines, -1 line 0 comments Download
D Source/devtools/front_end/timeline/TimelineOverviewPane.js View 1 chunk +0 lines, -482 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelinePanel.js View 5 chunks +14 lines, -10 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineView.js View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M Source/devtools/front_end/timeline/module.json View 1 chunk +0 lines, -1 line 0 comments Download
M Source/devtools/front_end/timeline/timelinePanel.css View 1 1 chunk +0 lines, -5 lines 0 comments Download
M Source/devtools/front_end/ui_lazy/TimelineGrid.js View 1 chunk +1 line, -1 line 0 comments Download
A + Source/devtools/front_end/ui_lazy/TimelineOverviewPane.js View 1 15 chunks +41 lines, -61 lines 0 comments Download
M Source/devtools/front_end/ui_lazy/module.json View 1 chunk +2 lines, -1 line 0 comments Download
M Source/devtools/front_end/ui_lazy/timelineGrid.css View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
alph
ptal
4 years, 10 months ago (2015-06-10 14:26:30 UTC) #2
yurys
lgtm https://codereview.chromium.org/1178563002/diff/1/Source/devtools/front_end/network/NetworkLogView.js File Source/devtools/front_end/network/NetworkLogView.js (right): https://codereview.chromium.org/1178563002/diff/1/Source/devtools/front_end/network/NetworkLogView.js#newcode2026 Source/devtools/front_end/network/NetworkLogView.js:2026: RequestSelected: Symbol("RequestSelected"), Although I agree that Symbols would ...
4 years, 10 months ago (2015-06-11 15:33:37 UTC) #3
alph
https://codereview.chromium.org/1178563002/diff/1/Source/devtools/front_end/network/NetworkLogView.js File Source/devtools/front_end/network/NetworkLogView.js (right): https://codereview.chromium.org/1178563002/diff/1/Source/devtools/front_end/network/NetworkLogView.js#newcode2026 Source/devtools/front_end/network/NetworkLogView.js:2026: RequestSelected: Symbol("RequestSelected"), On 2015/06/11 15:33:36, yurys wrote: > Although ...
4 years, 10 months ago (2015-06-11 16:35:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1178563002/40001
4 years, 10 months ago (2015-06-11 17:04:35 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2015-06-11 18:33:10 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196966

Powered by Google App Engine
This is Rietveld 408576698