Issue 1178553002: Use visual overflow rect as cull rect for table-cell box-decorations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1178553002: Use visual overflow rect as cull rect for table-cell box-decorations (Closed)

Created:
5 years, 6 months ago by fs

Modified:
5 years, 6 months ago

Reviewers:
chrishtr

CC:
blink-reviews, blink-reviews-paint_chromium.org, dshwang, slimming-paint-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Use visual overflow rect as cull rect for table-cell box-decorations The TableCellPainter::paintRect helper defines a border rect, so can't be used as the cull rect. Use the visual overflow rect instead. TEST=fast/box-shadow/basic-shadows.html (S.P. strict cull rect) BUG=498549 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196887

Patch Set 1 #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	Source/core/paint/TableCellPainter.cpp	View		1 chunk	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1178553002/1

5 years, 6 months ago (2015-06-10 18:11:37 UTC) #5

commit-bot: I haz the power

5 years, 6 months ago (2015-06-10 18:15:04 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196887

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages