Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 1178533002: X87: Vector ICs: ClassLiterals need to allocate a vector slot for home objects. (Closed)

Created:
5 years, 6 months ago by chunyang.dai
Modified:
5 years, 6 months ago
Reviewers:
Weiliang
CC:
v8-dev, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Vector ICs: ClassLiterals need to allocate a vector slot for home objects. port b27016b78a7dd58dc682eed51500ba603b3e46b0 (r28827). original commit message: BUG= R=weiliang.lin@intel.com Committed: https://chromium.googlesource.com/v8/v8/+/3df35e3f94c67cd0d08586ef4ad5f931ac3d8017

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M src/x87/full-codegen-x87.cc View 4 chunks +12 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
chunyang.dai
PTAL.
5 years, 6 months ago (2015-06-11 08:43:34 UTC) #2
Weiliang
lgtm
5 years, 6 months ago (2015-06-11 09:01:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1178533002/1
5 years, 6 months ago (2015-06-11 09:01:53 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/1222)
5 years, 6 months ago (2015-06-11 09:28:54 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3df35e3f94c67cd0d08586ef4ad5f931ac3d8017 Cr-Commit-Position: refs/heads/master@{#28951}
5 years, 6 months ago (2015-06-11 15:56:11 UTC) #8
chunyang.dai
5 years, 6 months ago (2015-06-11 15:56:20 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3df35e3f94c67cd0d08586ef4ad5f931ac3d8017 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698