fixes #215, removes special case for length

lib/src/codegen/js_codegen.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dev_compiler.src.codegen.js_codegen;
 
 import 'dart:collection' show HashSet, HashMap, SplayTreeSet;
 
 import 'package:analyzer/analyzer.dart' hide ConstantEvaluator;
 import 'package:analyzer/src/generated/ast.dart' hide ConstantEvaluator;
@@ skipping 2652 matching lines @@
     if (name == '[]') {
       name = 'get';
     } else if (name == '[]=') {
       name = 'set';
     } else if (name == '-' && unary) {
       name = 'unary-';
     }
 
     // Dart "extension" methods. Used for JS Array, Boolean, Number, String.
     if (allowExtensions && _extensionTypes.contains(type.element)) {
-      // Special case `length`. We can call it directly.
-      if (name != 'length') return js.call('dartx.#', _propertyName(name));
+      return js.call('dartx.#', _propertyName(name));

[vsm, 2015/06/10 17:00:46]

Will this really fix the broken text example?

There, I'm seeing this:

core.print(dart.dload(exports.l, 'length'));

[Jennifer Messerly, 2015/06/10 17:13:16]

yup. It works because of this logic:
https://github.com/dart-lang/dev_compiler/blob/master/lib/runtime/dart_runtim...

for dynamic dispatch to a Dart type or a Dart "extension type", we hide all JS
methods, that's why it's not finding "length", but it will find [dartx.length]

     }
 
     return _propertyName(name);
   }
 
   bool _externalOrNative(node) =>
       node.externalKeyword != null || _functionBody(node) is NativeFunctionBody;
 
   FunctionBody _functionBody(node) =>
       node is FunctionDeclaration ? node.functionExpression.body : node.body;
@@ skipping 88 matching lines @@
 
 /// A special kind of element created by the compiler, signifying a temporary
 /// variable. These objects use instance equality, and should be shared
 /// everywhere in the tree where they are treated as the same variable.
 class TemporaryVariableElement extends LocalVariableElementImpl {
   TemporaryVariableElement.forNode(Identifier name) : super.forNode(name);
 
   int get hashCode => identityHashCode(this);
   bool operator ==(Object other) => identical(this, other);
 }