Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(656)

Unified Diff: content/browser/accessibility/dump_accessibility_tree_browsertest.cc

Issue 11785038: Update and rebaseline many DumpAccessibilityTree tests. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/accessibility/dump_accessibility_tree_browsertest.cc
diff --git a/content/browser/accessibility/dump_accessibility_tree_browsertest.cc b/content/browser/accessibility/dump_accessibility_tree_browsertest.cc
index 72b07bd7f95156e1c9f0747f228079f644d4aa59..f7f0fc7ee0f04b8ac3ace3ba76b16d4a56a5399a 100644
--- a/content/browser/accessibility/dump_accessibility_tree_browsertest.cc
+++ b/content/browser/accessibility/dump_accessibility_tree_browsertest.cc
@@ -238,8 +238,7 @@ IN_PROC_BROWSER_TEST_F(DumpAccessibilityTreeTest,
// Broken by http://trac.webkit.org/137512
// Tracked in http://crbug.com/165838
aboxhall 2013/01/08 16:43:51 Is this comment still necessary?
dmazzoni 2013/01/08 18:21:02 You're right. I deleted all of the references to b
-IN_PROC_BROWSER_TEST_F(DumpAccessibilityTreeTest,
- DISABLED_AccessibilityAriaCombobox) {
+IN_PROC_BROWSER_TEST_F(DumpAccessibilityTreeTest, AccessibilityAriaCombobox) {
RunTest(FILE_PATH_LITERAL("aria-combobox.html"));
}
@@ -257,8 +256,7 @@ IN_PROC_BROWSER_TEST_F(DumpAccessibilityTreeTest, AccessibilityButtonNameCalc) {
// TODO(dmazzoni): rebaseline and enable after this WebKit change is rolled:
// https://bugs.webkit.org/show_bug.cgi?id=96323
aboxhall 2013/01/08 16:43:51 Should this comment be removed?
-IN_PROC_BROWSER_TEST_F(DumpAccessibilityTreeTest,
- DISABLED_AccessibilityCanvas) {
+IN_PROC_BROWSER_TEST_F(DumpAccessibilityTreeTest, AccessibilityCanvas) {
RunTest(FILE_PATH_LITERAL("canvas.html"));
}
@@ -267,21 +265,12 @@ IN_PROC_BROWSER_TEST_F(DumpAccessibilityTreeTest,
RunTest(FILE_PATH_LITERAL("checkbox-name-calc.html"));
}
-// TODO(dimich): Started to fail in Chrome r149732 (crbug 140397)
-#if defined(OS_WIN)
-#define MAYBE_AccessibilityContenteditableDescendants \
- DISABLED_AccessibilityContenteditableDescendants
-#else
-#define MAYBE_AccessibilityContenteditableDescendants \
- AccessibilityContenteditableDescendants
-#endif
-
IN_PROC_BROWSER_TEST_F(DumpAccessibilityTreeTest, AccessibilityDiv) {
RunTest(FILE_PATH_LITERAL("div.html"));
}
IN_PROC_BROWSER_TEST_F(DumpAccessibilityTreeTest,
- MAYBE_AccessibilityContenteditableDescendants) {
+ AccessibilityContenteditableDescendants) {
RunTest(FILE_PATH_LITERAL("contenteditable-descendants.html"));
}
@@ -325,7 +314,7 @@ IN_PROC_BROWSER_TEST_F(DumpAccessibilityTreeTest, AccessibilitySpinButton) {
// TODO(dmazzoni): rebaseline and enable after this WebKit change is rolled:
// https://bugs.webkit.org/show_bug.cgi?id=96323
aboxhall 2013/01/08 16:43:51 Similarly, I assume this comment is no longer requ
IN_PROC_BROWSER_TEST_F(DumpAccessibilityTreeTest,
- DISABLED_AccessibilityToggleButton) {
+ AccessibilityToggleButton) {
RunTest(FILE_PATH_LITERAL("togglebutton.html"));
}

Powered by Google App Engine
This is Rietveld 408576698