Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 11785037: Copy chrome/app/theme (x) close images to ui/resources. (Closed)

Created:
7 years, 11 months ago by msw
Modified:
7 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, oshima+watch_chromium.org
Visibility:
Public.

Description

Copy chrome/app/theme (x) close images to ui/resources. Add ui/resources/default_[1|2]00_percent/close_dialog*.png (copied from chrome/app/theme/default_[1|2]00_percent/web_ui_close*.png) (these are the most up-to-date image that we want to use) Add IDR_CLOSE_DIALOG[_H|_P] to ui_resources.grd TODO(followup): Remove IDR_WEB_UI_CLOSE* and images, use IDR_CLOSE_DIALOG*. (that will depend on WIP CL https://codereview.chromium.org/11830002) BUG=166075 TEST=NONE R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175862

Patch Set 1 #

Patch Set 2 : Working on getting ui/resources from chrome://theme. #

Patch Set 3 : Split out chrome://theme changes, use IDR_WEB_UI_CLOSE* in overlay.css. #

Patch Set 4 : Revert example extension changes and restore chrome/browser/resources/shared/images. #

Patch Set 5 : Sync and rebase. #

Messages

Total messages: 2 (0 generated)
msw
Hey Scott, please take a look; thanks! Trybots fail on binary files.
7 years, 11 months ago (2013-01-09 01:27:54 UTC) #1
sky
7 years, 11 months ago (2013-01-09 16:55:54 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698