Continue work on requestAutocomplete dialog

Continue work on requestAutocomplete dialog

1) show hover effect on rows
2) add placeholder resources for menu buttons
3) make clicks on rows pop up the suggestion menu

BUG=157273
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175696

[Evan Stade, 2013-01-08 02:01:07]

see: http://i.imgur.com/KaoC2.png

it's pretty ugly because I have thus far only worried about functionality. But
this screenshot should hopefully give you a better idea of what you're
reviewing. Note that the bottom row is grey because it's hovered (my cursor
doesn't show up in the screenshot).

[sky, 2013-01-08 05:05:11]

https://codereview.chromium.org/11785035/diff/3001/chrome/browser/ui/views/au...
File chrome/browser/ui/views/autofill/autofill_dialog_views.cc (right):

https://codereview.chromium.org/11785035/diff/3001/chrome/browser/ui/views/au...
chrome/browser/ui/views/autofill/autofill_dialog_views.cc:48: views::View*
controls,
nit: fix indentation.

https://codereview.chromium.org/11785035/diff/3001/chrome/browser/ui/views/au...
chrome/browser/ui/views/autofill/autofill_dialog_views.cc:82: void
AutofillDialogViews::SectionContainer::SetForwardMouseEvents(
Do you really need this? Can forward_mouse_events_ always be true?

https://codereview.chromium.org/11785035/diff/3001/chrome/browser/ui/views/au...
chrome/browser/ui/views/autofill/autofill_dialog_views.cc:106:
proxy_button_->OnMouseExited(ProxyEvent(event));
Is proxy_button_ a descendant? Does SectionContainer contain any views that want
mouse events, like the radio box titled 'Use as shipping address' in the screen
shot?

[Evan Stade, 2013-01-08 21:41:14]

https://codereview.chromium.org/11785035/diff/3001/chrome/browser/ui/views/au...
File chrome/browser/ui/views/autofill/autofill_dialog_views.cc (right):

https://codereview.chromium.org/11785035/diff/3001/chrome/browser/ui/views/au...
chrome/browser/ui/views/autofill/autofill_dialog_views.cc:48: views::View*
controls,
On 2013/01/08 05:05:12, sky wrote:
> nit: fix indentation.

Done.

https://codereview.chromium.org/11785035/diff/3001/chrome/browser/ui/views/au...
chrome/browser/ui/views/autofill/autofill_dialog_views.cc:82: void
AutofillDialogViews::SectionContainer::SetForwardMouseEvents(
On 2013/01/08 05:05:12, sky wrote:
> Do you really need this? Can forward_mouse_events_ always be true?

it's false when in edit mode. In that case, you have to actually click on the
[v] button.

https://codereview.chromium.org/11785035/diff/3001/chrome/browser/ui/views/au...
chrome/browser/ui/views/autofill/autofill_dialog_views.cc:106:
proxy_button_->OnMouseExited(ProxyEvent(event));
On 2013/01/08 05:05:12, sky wrote:
> Is proxy_button_ a descendant? Does SectionContainer contain any views that
want
> mouse events, like the radio box titled 'Use as shipping address' in the
screen
> shot?

yes it is, although I don't think it has to be for this to work. The radio
button is a descendant of SectinContainer, and it still works.

[sky, 2013-01-08 22:46:24]

LGTM

[commit-bot: I haz the power, 2013-01-09 00:43:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/estade@chromium.org/11785035/15001

[commit-bot: I haz the power, 2013-01-09 03:30:38]

Retried try job too often on win_rel for step(s) browser_tests