Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 11785030: GeolocationConfirmInfoBarDelegate* -> GeolocationInfoBarDelegate*, for consistency with other infob… (Closed)

Created:
7 years, 11 months ago by Peter Kasting
Modified:
7 years, 8 months ago
Reviewers:
sky, John Knottenbelt
CC:
chromium-reviews
Visibility:
Public.

Description

GeolocationConfirmInfoBarDelegate* -> GeolocationInfoBarDelegate*, for consistency with other infobars and brevity. BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194478

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -334 lines) Patch
D chrome/browser/geolocation/geolocation_confirm_infobar_delegate.h View 1 2 3 4 1 chunk +0 lines, -65 lines 0 comments Download
D chrome/browser/geolocation/geolocation_confirm_infobar_delegate.cc View 1 2 3 4 1 chunk +0 lines, -125 lines 0 comments Download
D chrome/browser/geolocation/geolocation_confirm_infobar_delegate_android.h View 1 2 3 4 1 chunk +0 lines, -33 lines 0 comments Download
D chrome/browser/geolocation/geolocation_confirm_infobar_delegate_android.cc View 1 2 3 4 1 chunk +0 lines, -52 lines 0 comments Download
A + chrome/browser/geolocation/geolocation_infobar_delegate.h View 1 2 3 4 4 chunks +11 lines, -12 lines 0 comments Download
A + chrome/browser/geolocation/geolocation_infobar_delegate.cc View 1 2 3 4 5 6 5 chunks +18 lines, -19 lines 0 comments Download
A + chrome/browser/geolocation/geolocation_infobar_delegate_android.h View 2 chunks +7 lines, -8 lines 0 comments Download
A + chrome/browser/geolocation/geolocation_infobar_delegate_android.cc View 1 2 3 chunks +8 lines, -11 lines 0 comments Download
M chrome/browser/geolocation/geolocation_infobar_queue_controller.h View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/geolocation/geolocation_infobar_queue_controller.cc View 1 2 3 4 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Peter Kasting
7 years, 11 months ago (2013-01-08 00:20:28 UTC) #1
Peter Kasting
+sky for chrome/ OWNERS
7 years, 11 months ago (2013-01-08 01:31:31 UTC) #2
sky
LGTM
7 years, 11 months ago (2013-01-08 04:53:26 UTC) #3
John Knottenbelt
7 years, 11 months ago (2013-01-08 10:19:42 UTC) #4
LGTM. Thanks, Peter!

Powered by Google App Engine
This is Rietveld 408576698