Fixing unittest: ensure 'wait-until-done' is posted before we reach the end of

pkg/unittest/lib/src/config.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of unittest;
 
 /**
  * Hooks to configure the unittest library for different platforms. This class
  * implements the API in a platform-independent way. Tests that want to take
  * advantage of the platform can create a subclass and override methods from
@@ skipping 15 matching lines @@
   /**
    * If true, then tests are started automatically (otherwise [runTests]
    * must be called explicitly after the tests are set up.
    */
   get autoStart => true;
 
   /**
    * Called as soon as the unittest framework becomes initialized. This is done
    * even before tests are added to the test framework. It might be used to
    * determine/debug errors that occur before the test harness starts executing.
+   * It is also used to tell the vm or browser that tests are going to be run
+   * asynchronously and that the process should wait until they are done.
    */
-  void onInit() {}
-
-  /**
-   * Called as soon as the unittest framework starts running. Used commonly to
-   * tell the vm or browser that tests are still running and the process should
-   * wait until they are done.
-   */
-  void onStart() {
+  void onInit() {
     _receivePort = new ReceivePort();
     _postMessage('unittest-suite-wait-for-done');
   }
 
+  /** Called as soon as the unittest framework starts running. */
+  void onStart() {}
+
   /**
    * Called when each test starts. Useful to show intermediate progress on
    * a test suite.
    */
   void onTestStart(TestCase testCase) {
     currentTestCase = testCase;
   }
 
   /**
    * Called when each test is completed. Useful to show intermediate progress on
@@ skipping 63 matching lines @@
     } else if (failed == 0 && errors == 0 && uncaughtError == null) {
       print('All $passed tests passed.');
       success = true;
     } else {
       if (uncaughtError != null) {
         print('Top-level uncaught error: $uncaughtError');
       }
       print('$passed PASSED, $failed FAILED, $errors ERRORS');
     }
 
-    _receivePort.close();
     if (success) {
       _postMessage('unittest-suite-success');
+    _receivePort.close();
     } else {
+    _receivePort.close();
       throw new Exception('Some tests failed.');
     }
   }
 
   String _indent(String str) {
     // TODO(nweiz): Use this simpler code once issue 2980 is fixed.
     // return str.replaceAll(new RegExp("^", multiLine: true), "  ");
 
     return Strings.join(str.split("\n").mappedBy((line) => "  $line"), "\n");
   }
 
   /** Handle errors that happen outside the tests. */
   // TODO(vsm): figure out how to expose the stack trace here
   // Currently e.message works in dartium, but not in dartc.
   handleExternalError(e, String message) =>
       _reportTestError('$message\nCaught $e', '');
 
   _postMessage(String message) {
     // In dart2js browser tests, the JavaScript-based test controller
     // intercepts calls to print and listens for "secret" messages.
     print(message);
   }
 }