Do not commit InstantLoader server redirects till the page supports instant.

Do not commit InstantLoader server redirects till the page supports instant.

This will allow the instant page to redirect based on country specific pages.
The change is a somewhat temporary fix and will be redundant when
InstantLoader lives in its own privileged process.

BUG=167982
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175585

[Shishir, 2013-01-07 20:18:08]

PTAL

[sreeram, 2013-01-08 00:50:03]

https://codereview.chromium.org/11785025/diff/1/chrome/browser/instant/instan...
File chrome/browser/instant/instant_controller.cc (right):

https://codereview.chromium.org/11785025/diff/1/chrome/browser/instant/instan...
chrome/browser/instant/instant_controller.cc:880: return;
Put this before the GURL declaration above, so we avoid the object construction
if this condition is hit.

Also, do we really need to have this bool passed to us? What would go wrong if
we just did this:

if (!loader_->supports_instant())
  return;

If that works, you can get rid of all the other code in this CL, no?

[Shishir, 2013-01-08 01:01:12]

PTAL

https://codereview.chromium.org/11785025/diff/1/chrome/browser/instant/instan...
File chrome/browser/instant/instant_controller.cc (right):

https://codereview.chromium.org/11785025/diff/1/chrome/browser/instant/instan...
chrome/browser/instant/instant_controller.cc:880: return;
On 2013/01/08 00:50:03, sreeram wrote:
> Put this before the GURL declaration above, so we avoid the object
construction
> if this condition is hit.
> 
> Also, do we really need to have this bool passed to us? What would go wrong if
> we just did this:
> 
> if (!loader_->supports_instant())
>   return;
> 
> If that works, you can get rid of all the other code in this CL, no?

Forgot that the instant page had to call show to show up initially.

All Done.

[sreeram, 2013-01-08 01:03:23]

lgtm

[commit-bot: I haz the power, 2013-01-08 17:50:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/shishir@chromium.org/11785025/6001

[commit-bot: I haz the power, 2013-01-08 21:56:36]

Change committed as 175585