Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 11785025: Do not commit InstantLoader server redirects till the page supports instant. (Closed)

Created:
7 years, 11 months ago by Shishir
Modified:
7 years, 11 months ago
Reviewers:
sreeram
CC:
chromium-reviews, melevin, samarth, sreeram, gideonwald, dominich, David Black, Jered
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Do not commit InstantLoader server redirects till the page supports instant. This will allow the instant page to redirect based on country specific pages. The change is a somewhat temporary fix and will be redundant when InstantLoader lives in its own privileged process. BUG=167982 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175585

Patch Set 1 #

Total comments: 2

Patch Set 2 : Not committing on any load before InstantSupportDetermined. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/browser/instant/instant_controller.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Shishir
PTAL
7 years, 11 months ago (2013-01-07 20:18:08 UTC) #1
sreeram
https://codereview.chromium.org/11785025/diff/1/chrome/browser/instant/instant_controller.cc File chrome/browser/instant/instant_controller.cc (right): https://codereview.chromium.org/11785025/diff/1/chrome/browser/instant/instant_controller.cc#newcode880 chrome/browser/instant/instant_controller.cc:880: return; Put this before the GURL declaration above, so ...
7 years, 11 months ago (2013-01-08 00:50:03 UTC) #2
Shishir
PTAL https://codereview.chromium.org/11785025/diff/1/chrome/browser/instant/instant_controller.cc File chrome/browser/instant/instant_controller.cc (right): https://codereview.chromium.org/11785025/diff/1/chrome/browser/instant/instant_controller.cc#newcode880 chrome/browser/instant/instant_controller.cc:880: return; On 2013/01/08 00:50:03, sreeram wrote: > Put ...
7 years, 11 months ago (2013-01-08 01:01:12 UTC) #3
sreeram
lgtm
7 years, 11 months ago (2013-01-08 01:03:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shishir@chromium.org/11785025/6001
7 years, 11 months ago (2013-01-08 17:50:33 UTC) #5
commit-bot: I haz the power
7 years, 11 months ago (2013-01-08 21:56:36 UTC) #6
Message was sent while issue was closed.
Change committed as 175585

Powered by Google App Engine
This is Rietveld 408576698