Issue 11785020: Disable PromoResourceServiceTest.NotificationPromoTest on all platforms

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11785020: Disable PromoResourceServiceTest.NotificationPromoTest on all platforms (Closed)

Created:
7 years, 11 months ago by jochen (gone - plz use gerrit)

Modified:
7 years, 11 months ago

Reviewers:
achuithb, Dan Beam

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Disable PromoResourceServiceTest.NotificationPromoTest on all platforms This test hardcodes a date in Jan 2013, so it's broken now BUG=168561 TBR=achuith@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175332

Patch Set 1 #

Total comments: 1

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	chrome/browser/web_resource/promo_resource_service_unittest.cc	View		1 chunk	+3 lines, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Dan Beam

7 years, 11 months ago (2013-01-07 15:59:36 UTC) #2

Message was sent while issue was closed.

https://codereview.chromium.org/11785020/diff/1/chrome/browser/web_resource/p...
File chrome/browser/web_resource/promo_resource_service_unittest.cc (right):

https://codereview.chromium.org/11785020/diff/1/chrome/browser/web_resource/p...
chrome/browser/web_resource/promo_resource_service_unittest.cc:323: // hardcoded
a date in Jan 2013. Srzly?? http://crbug.com/168561
hahaha, I'll fix this.

Expand Messages | Collapse Messages