Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(948)

Unified Diff: chrome/common/startup_metric_utils.h

Issue 11785014: Record metrics for slow startups (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixup Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/startup_metric_utils.h
diff --git a/chrome/common/startup_metric_utils.h b/chrome/common/startup_metric_utils.h
index feeca61aeb41be96916822535e267f6dd6e2b7ef..6a5751ea9723590c1ec8779dcc0ae77e66a72ab7 100644
--- a/chrome/common/startup_metric_utils.h
+++ b/chrome/common/startup_metric_utils.h
@@ -5,6 +5,8 @@
#ifndef CHROME_COMMON_STARTUP_METRIC_UTILS_H_
#define CHROME_COMMON_STARTUP_METRIC_UTILS_H_
+#include <string>
+
#include "base/time.h"
// Utility functions to support metric collection for browser startup.
@@ -29,8 +31,27 @@ void SetNonBrowserUIDisplayed();
// timestamp.
void RecordMainEntryPointTime();
-// Return the time recorded by RecordMainEntryPointTime().
-const base::Time MainEntryStartTime();
+// Called just before the message loop is about to start. Entry point to record
+// startup stats.
+void OnBrowserStartupComplete();
+
+// Scoper that records the time period before it's distructed in a histogram
Scott Hess - ex-Googler 2013/01/07 21:47:25 s/distructed/destructed/ I often wonder about hav
jeremy 2013/01/10 15:08:39 Done.
+// with the given name. The histogram is only recorded for slow chrome startups.
+// Useful for trying to figure out what parts of Chrome cause slow startup.
+class ScopedSlowStartupUMA {
+ public:
+ explicit ScopedSlowStartupUMA(const std::string& histogram_name)
+ : start_time_(base::TimeTicks::Now()),
+ histogram_name_(histogram_name) {}
+
+ ~ScopedSlowStartupUMA();
+
+ private:
+ base::TimeTicks start_time_;
+ std::string histogram_name_;
+
+ DISALLOW_COPY_AND_ASSIGN(ScopedSlowStartupUMA);
+};
} // namespace startup_metric_utils

Powered by Google App Engine
This is Rietveld 408576698