Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(172)

Issue 1178483002: Merge page serializers [5/12] (Closed)

Created:
4 years, 10 months ago by Tiger (Sony Mobile)
Modified:
4 years, 10 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove duplicate xml declaration test Remove duplicate test WebPageNewSerializeTest.SerializeXMLHasRightDeclaration and clean up the existing test PageSerializerTest.XMLDeclaration slighly. -- This review is part of set aiming to merge the two existing page serializers, WebPageSerializerImpl and PageSerializer into the latter one. In addition to this it moves all the old tests from WebPageNewSerializerTest and WebPageSerializerTest to the newer PageSerializerTest structure and splits out a test for MHTML into the MHTMLTest file. Note: This is a rebase and split of https://codereview.chromium.org/68613003 from Opera which was reverted due to failing tests. In addition to the rebase some smaller fixes was done to accommodate to changes in the code from when it was first landed. BUG=328354 R=hajimehoshi@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196868

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -38 lines) Patch
M Source/web/tests/PageSerializerTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/WebPageNewSerializerTest.cpp View 1 chunk +0 lines, -23 lines 0 comments Download
D Source/web/tests/data/pageserializer/simple.xhtml View 1 chunk +0 lines, -10 lines 0 comments Download
A + Source/web/tests/data/pageserializer/xml/xmldecl.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
D Source/web/tests/data/pageserializer/xmldecl/xmldecl.xml View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Tiger (Sony Mobile)
PTAL
4 years, 10 months ago (2015-06-10 08:33:55 UTC) #1
hajimehoshi
lgtm
4 years, 10 months ago (2015-06-10 08:48:39 UTC) #2
philipj_slow
lgtm
4 years, 10 months ago (2015-06-10 09:10:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1178483002/1
4 years, 10 months ago (2015-06-10 12:42:04 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2015-06-10 13:52:55 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196868

Powered by Google App Engine
This is Rietveld 408576698