LayoutTests/fast/inline/vertical-align-text-inherit.html - Issue 1178473003: Vertical-aligned of LayoutText should not contribute to a layout.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/inline/vertical-align-text-inherit.html

Issue 1178473003: Vertical-aligned of LayoutText should not contribute to a layout. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <style>

	3 .container {

	4 background-color: yellow;

	5 display: inline-block;

	6 overflow: hidden;
	mstensho (USE GERRIT) 2015/06/10 11:40:41 The background-color, display, overflow, text-over The background-color, display, overflow, text-overflow, width and white-space properties are irrelevant, and just cause the text to be clipped with an ellipsis so that the pass condition text isn't fully visible. Can you remove them? changseok 2015/06/11 04:39:05 Of course, I can. =) I just mimicked the original Show quoted text On 2015/06/10 11:40:41, mstensho wrote: > The background-color, display, overflow, text-overflow, width and white-space > properties are irrelevant, and just cause the text to be clipped with an > ellipsis so that the pass condition text isn't fully visible. Can you remove > them? Of course, I can. =) I just mimicked the original bug introduced in crbug.com/496850
	7 text-overflow: ellipsis;

	8 width: 200px;

	9 white-space: nowrap;

	10 vertical-align: top;

	11 }

	12

	13 .green {

	14 background-color: green;
	mstensho (USE GERRIT) 2015/06/10 11:40:41 See my comment further below. This inline-block is See my comment further below. This inline-block is useful in the test, to stretch the height of the line box, but it doesn't really need a background color. changseok 2015/06/11 04:39:05 O.K I see. Show quoted text On 2015/06/10 11:40:41, mstensho wrote: > See my comment further below. This inline-block is useful in the test, to > stretch the height of the line box, but it doesn't really need a background > color. O.K I see.
	15 display: inline-block;

	16 width: 50px;

	17 height: 50px;

	18 }

	19 </style>

	20 <p>Test passes if a text in a yellow box is aligned with the bottom of a left gr een box.</p>

	21 Baseline.

	22 <div class="container">

	23 <div class="green"></div>

	24 This text should be aligned with the bottom of a left green box.
	mstensho (USE GERRIT) 2015/06/10 11:40:41 The baseline of this text, perhaps. Not the bottom The baseline of this text, perhaps. Not the bottom of the text. But that's hard to measure with the naked eye anyway. How about replacing this text with something like: <span>This text should</span> be on the same line. changseok 2015/06/11 04:39:05 This is neater. Show quoted text On 2015/06/10 11:40:41, mstensho wrote: > The baseline of this text, perhaps. Not the bottom of the text. But that's hard > to measure with the naked eye anyway. > > How about replacing this text with something like: > > <span>This text should</span> be on the same line. This is neater.
	25 </div>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/inline/vertical-align-text-inherit-expected.html » ('j') | Source/core/layout/line/InlineBox.h » ('J')