Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 117843002: Enable some webrtc content_browsertests on Android. (Closed)

Created:
7 years ago by wjia(left Chromium)
Modified:
6 years, 7 months ago
Reviewers:
phoglund_chromium
CC:
chromium-reviews, craigdh+watch_chromium.org, jam, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, darin-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

Enable some webrtc content_browsertests on Android. To prevent crashes, it's needed to use ISAC/16000 on Android. BUG=181069

Patch Set 1 #

Patch Set 2 : reload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -34 lines) Patch
M build/android/pylib/gtest/filter/content_browsertests_disabled View 2 chunks +11 lines, -11 lines 0 comments Download
M content/browser/media/webrtc_browsertest.cc View 17 chunks +34 lines, -3 lines 0 comments Download
M content/test/data/media/peerconnection-call.html View 5 chunks +24 lines, -20 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
wjia(left Chromium)
Please review cc and html files. I will clean up the txt file when it's ...
7 years ago (2013-12-18 05:35:23 UTC) #1
phoglund_chromium
On 2013/12/18 05:35:23, wjia wrote: > Please review cc and html files. I will clean ...
7 years ago (2013-12-18 11:25:52 UTC) #2
phoglund_chromium
7 years ago (2013-12-18 11:27:53 UTC) #3
> It seems WebrtcBrowserTest.CanSetupVideoCall and
> WebrtcBrowserTest.NegotiateUnsupportedVideoCodec were timed out. But they are
ok
> on my local machine. I will take closer look tomorrow.

Yes. My new audio tests have been running for a while on the chromium bots, and
they often crash, often timeout, and sometimes succeed. There are some general
problems that could even be for the browser test binary in general. I'm also
looking into this, so let's keep in touch where our investigations lead. I think
we can get away with enabling more tests for now to get more data points on the
bots, so I think it might be a good idea to enable the tests you suggest here
and see what sticks.

Powered by Google App Engine
This is Rietveld 408576698