Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: extensions/browser/api/cast_channel/logger_unittest.cc

Issue 1178423008: Provision to start base::SimpleTestTickClock at initial ticks Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/cast_channel/logger_unittest.cc
diff --git a/extensions/browser/api/cast_channel/logger_unittest.cc b/extensions/browser/api/cast_channel/logger_unittest.cc
index 617dcf8a93f3838fc464561e46ca413879030f6b..587591c7ec703075b530a3da7cdf6dcbf64c78c1 100644
--- a/extensions/browser/api/cast_channel/logger_unittest.cc
+++ b/extensions/browser/api/cast_channel/logger_unittest.cc
@@ -132,18 +132,19 @@ TEST_F(CastChannelLoggerTest, BasicLogging) {
{
const SocketEvent& event = aggregated_socket_event.socket_event(0);
EXPECT_EQ(EventType::CAST_SOCKET_CREATED, event.type());
- EXPECT_EQ(0, event.timestamp_micros());
+ // SimpleTestTickClock starts at 1 microsecond
+ EXPECT_EQ(1, event.timestamp_micros());
}
{
const SocketEvent& event = aggregated_socket_event.socket_event(1);
EXPECT_EQ(EventType::TCP_SOCKET_CONNECT, event.type());
- EXPECT_EQ(1, event.timestamp_micros());
+ EXPECT_EQ(2, event.timestamp_micros());
EXPECT_EQ("TCP socket", event.details());
}
{
const SocketEvent& event = aggregated_socket_event.socket_event(2);
EXPECT_EQ(EventType::SSL_SOCKET_CONNECT, event.type());
- EXPECT_EQ(3, event.timestamp_micros());
+ EXPECT_EQ(4, event.timestamp_micros());
EXPECT_EQ(-1, event.net_return_value());
}
}
@@ -155,19 +156,19 @@ TEST_F(CastChannelLoggerTest, BasicLogging) {
{
const SocketEvent& event = aggregated_socket_event.socket_event(0);
EXPECT_EQ(EventType::CAST_SOCKET_CREATED, event.type());
- EXPECT_EQ(2, event.timestamp_micros());
+ EXPECT_EQ(3, event.timestamp_micros());
}
{
const SocketEvent& event = aggregated_socket_event.socket_event(1);
EXPECT_EQ(EventType::MESSAGE_ENQUEUED, event.type());
- EXPECT_EQ(4, event.timestamp_micros());
+ EXPECT_EQ(5, event.timestamp_micros());
EXPECT_FALSE(event.has_message_namespace());
EXPECT_EQ("details", event.details());
}
{
const SocketEvent& event = aggregated_socket_event.socket_event(2);
EXPECT_EQ(EventType::AUTH_CHALLENGE_REPLY, event.type());
- EXPECT_EQ(5, event.timestamp_micros());
+ EXPECT_EQ(6, event.timestamp_micros());
EXPECT_EQ(proto::CHALLENGE_REPLY_ERROR_NO_RESPONSE,
event.challenge_reply_error_type());
EXPECT_FALSE(event.has_net_return_value());
@@ -176,7 +177,7 @@ TEST_F(CastChannelLoggerTest, BasicLogging) {
{
const SocketEvent& event = aggregated_socket_event.socket_event(3);
EXPECT_EQ(EventType::AUTH_CHALLENGE_REPLY, event.type());
- EXPECT_EQ(6, event.timestamp_micros());
+ EXPECT_EQ(7, event.timestamp_micros());
EXPECT_EQ(proto::CHALLENGE_REPLY_ERROR_CERT_PARSING_FAILED,
event.challenge_reply_error_type());
EXPECT_FALSE(event.has_net_return_value());
@@ -311,7 +312,7 @@ TEST_F(CastChannelLoggerTest, TooManyEvents) {
const AggregatedSocketEvent& aggregated_socket_event =
log->aggregated_socket_event(0);
ASSERT_EQ(kMaxEventsPerSocket, aggregated_socket_event.socket_event_size());
- EXPECT_EQ(5, aggregated_socket_event.socket_event(0).timestamp_micros());
+ EXPECT_EQ(6, aggregated_socket_event.socket_event(0).timestamp_micros());
}
TEST_F(CastChannelLoggerTest, Reset) {

Powered by Google App Engine
This is Rietveld 408576698