Side by Side Diff: ui/app_list/cocoa/app_list_view.h
Issue 11784034:
Skeleton for app_list on OSX, and refactoring for enable_app_list=1 on OS=="mac". (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: style tweaks
Created 7 years, 11 months ago
Use n/p to move between diff chunks;
N/P to move between comments.
Draft comments are only viewable by you.
On 2013/01/08 07:25:27, sail wrote:
> Would AppListWindow or AppListViewWindow be a better name?
Also, where is this bubble being shown from (a browser toolbar, web page, OS X
dock, etc...)? If it's from the browser window you'll probably want a bunch of
standard stuff that the other browser window bubbles already have. To get this
you'll either have to refactor the bubble code from chrome/browser/ui/cocoa or
move this class.
tapted
2013/01/09 04:29:49
It will be a bubble shown from the OSX Dock, possi
On 2013/01/08 07:41:12, sail wrote:
> On 2013/01/08 07:25:27, sail wrote:
> > Would AppListWindow or AppListViewWindow be a better name?
>
> Also, where is this bubble being shown from (a browser toolbar, web page, OS X
> dock, etc...)? If it's from the browser window you'll probably want a bunch of
> standard stuff that the other browser window bubbles already have. To get this
> you'll either have to refactor the bubble code from chrome/browser/ui/cocoa or
> move this class.
It will be a bubble shown from the OSX Dock, possibly without any browser
windows visible. (And, on Windows, there is a flow where the user does not have
Chrome Browser visibly installed at all, but that might not be a priority for
the OSX app_list port). I did have an initial look at the various cocoa bubbles
under chrome/browser -- I will certainly be mining them for ideas, and mapping
out refactoring opportunities where I can. Although, there is not currently a
/ui/cocoa (like there is a /ui/views), so there are some logistics to tackle
there.
There's a tricky balance between how closely to mirror the toolkit-views
/ui/app_list and whether to lean on cocoa parts in /chrome/browser/ui. The
current plan is to keep the new app_list things out of /chrome/browser as much
as possible, to minimise coupling.
The rationale here for the name, "AppListView" was more on the "mirror
toolkit-views" side of the balance. At a high level, I think the existing
approach there is to populate the view and wrap it in a native window once we
know how big the view will be, and use the view as the main handle in the
controller. For the initial skeleton I wanted something basic, so it's just the
NSWindow with no views yet. However, you are right that it is confusing.
I've renamed this to AppListViewWindow (and updated filenames/gyp/etc.) so that
it's clearer that it's still the NSWindow at this point.
Issue 11784034: Skeleton for app_list on OSX, and refactoring for enable_app_list=1 on OS=="mac".
(Closed)
Created 7 years, 11 months ago by tapted
Modified 7 years, 11 months ago
Reviewers: xiyuan, sky, sail
Base URL: https://chromium.googlesource.com/chromium/src.git@master
Comments: 31