test/unittests/compiler/graph-unittest.cc - Issue 1178403004: [turbofan] Use appropriate type for NodeId.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/unittests/compiler/graph-unittest.cc

Issue 1178403004: [turbofan] Use appropriate type for NodeId. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix useless static_cast. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/unittests/compiler/graph-unittest.cc

diff --git a/test/unittests/compiler/graph-unittest.cc b/test/unittests/compiler/graph-unittest.cc

index d2ab3c3a2652c843bd527dc0861b9c8e7a2b9eae..c7c79b44f4eff81da8e53b6a337974fce9003fa6 100644

--- a/test/unittests/compiler/graph-unittest.cc

+++ b/test/unittests/compiler/graph-unittest.cc

@@ -136,8 +136,8 @@ TEST_F(GraphTest, NewNode) {

Node* n0 = graph()->NewNode(&kDummyOperator);

Node* n1 = graph()->NewNode(&kDummyOperator);

EXPECT_NE(n0, n1);

- EXPECT_LT(0, n0->id());

- EXPECT_LT(0, n1->id());

+ EXPECT_LT(0u, n0->id());

+ EXPECT_LT(0u, n1->id());

EXPECT_NE(n0->id(), n1->id());

EXPECT_EQ(&kDummyOperator, n0->op());

EXPECT_EQ(&kDummyOperator, n1->op());

« no previous file with comments | « test/unittests/compiler/graph-reducer-unittest.cc ('k') | no next file » | no next file with comments »