src/compiler/graph.cc - Issue 1178403004: [turbofan] Use appropriate type for NodeId.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/graph.cc

Issue 1178403004: [turbofan] Use appropriate type for NodeId. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix useless static_cast. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/graph.cc

diff --git a/src/compiler/graph.cc b/src/compiler/graph.cc

index 193861187ba1f8aeec349c6787a7c4e133f55a5b..07bf2ba44eb7cdb068796d0ed179f628172c444c 100644

--- a/src/compiler/graph.cc

+++ b/src/compiler/graph.cc

@@ -53,7 +53,7 @@ Node* Graph::NewNode(const Operator* op, int input_count, Node** inputs,

NodeId Graph::NextNodeId() {

NodeId const id = next_node_id_;

- CHECK(!base::bits::SignedAddOverflow32(id, 1, &next_node_id_));

+ CHECK(!base::bits::UnsignedAddOverflow32(id, 1, &next_node_id_));

return id;

}

« no previous file with comments | « src/compiler/graph.h ('k') | src/compiler/graph-reducer.h » ('j') | no next file with comments »