src/compiler/simplified-lowering.cc - Issue 1178403004: [turbofan] Use appropriate type for NodeId.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/simplified-lowering.cc

Issue 1178403004: [turbofan] Use appropriate type for NodeId. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix compilation errors. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/simplified-lowering.cc

diff --git a/src/compiler/simplified-lowering.cc b/src/compiler/simplified-lowering.cc

index 482a283e855bd54fef1a4bf77c235333dad4d926..e7e0677491b9625e09b46fb2abfe34d01ebea7ad 100644

--- a/src/compiler/simplified-lowering.cc

+++ b/src/compiler/simplified-lowering.cc

@@ -72,7 +72,7 @@ class RepresentationSelector {

SourcePositionTable* source_positions)

: jsgraph_(jsgraph),

count_(jsgraph->graph()->NodeCount()),

- info_(zone->NewArray<NodeInfo>(count_)),

+ info_(zone->NewArray<NodeInfo>(static_cast<int>(count_))),

Sven Panne 2015/06/12 11:19:36 AFAICT, we don't need the static_cast here. By des

nodes_(zone),

replacements_(zone),

phase_(PROPAGATE),

@@ -1085,7 +1085,7 @@ class RepresentationSelector {

private:

JSGraph* jsgraph_;

- int count_; // number of nodes in the graph

+ size_t const count_; // number of nodes in the graph

NodeInfo* info_; // node id -> usage information

NodeVector nodes_; // collected nodes

NodeVector replacements_; // replacements to be done after lowering

« no previous file with comments | « src/compiler/schedule.cc ('k') | test/cctest/compiler/test-js-constant-cache.cc » ('j') | no next file with comments »