[turbofan] Use appropriate type for NodeId.

test/unittests/compiler/graph-reducer-unittest.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/common-operator.h"
 #include "src/compiler/graph.h"
 #include "src/compiler/node.h"
 #include "src/compiler/operator.h"
 #include "test/unittests/compiler/graph-reducer-unittest.h"
 #include "test/unittests/test-utils.h"
@@ skipping 506 matching lines @@
 
 
 TEST_F(GraphReducerTest, ReduceInPlace1) {
   Node* n1 = graph()->NewNode(&kOpA0);
   Node* end = graph()->NewNode(&kOpA1, n1);
   graph()->SetEnd(end);
 
   // Tests A* => B* with in-place updates.
   InPlaceABReducer r;
   for (int i = 0; i < 3; i++) {
-    int before = graph()->NodeCount();
+    size_t before = graph()->NodeCount();
     ReduceGraph(&r);
     EXPECT_EQ(before, graph()->NodeCount());
     EXPECT_EQ(&kOpB0, n1->op());
     EXPECT_EQ(&kOpB1, end->op());
     EXPECT_EQ(n1, end->InputAt(0));
   }
 }
 
 
 TEST_F(GraphReducerTest, ReduceInPlace2) {
   Node* n1 = graph()->NewNode(&kOpA0);
   Node* n2 = graph()->NewNode(&kOpA1, n1);
   Node* n3 = graph()->NewNode(&kOpA1, n1);
   Node* end = graph()->NewNode(&kOpA2, n2, n3);
   graph()->SetEnd(end);
 
   // Tests A* => B* with in-place updates.
   InPlaceABReducer r;
   for (int i = 0; i < 3; i++) {
-    int before = graph()->NodeCount();
+    size_t before = graph()->NodeCount();
     ReduceGraph(&r);
     EXPECT_EQ(before, graph()->NodeCount());
     EXPECT_EQ(&kOpB0, n1->op());
     EXPECT_EQ(&kOpB1, n2->op());
     EXPECT_EQ(n1, n2->InputAt(0));
     EXPECT_EQ(&kOpB1, n3->op());
     EXPECT_EQ(n1, n3->InputAt(0));
     EXPECT_EQ(&kOpB2, end->op());
     EXPECT_EQ(n2, end->InputAt(0));
     EXPECT_EQ(n3, end->InputAt(1));
   }
 }
 
 
 TEST_F(GraphReducerTest, ReduceNew1) {
   Node* n1 = graph()->NewNode(&kOpA0);
   Node* n2 = graph()->NewNode(&kOpA1, n1);
   Node* n3 = graph()->NewNode(&kOpA1, n1);
   Node* end = graph()->NewNode(&kOpA2, n2, n3);
   graph()->SetEnd(end);
 
   NewABReducer r(graph());
   // Tests A* => B* while creating new nodes.
   for (int i = 0; i < 3; i++) {
-    int before = graph()->NodeCount();
+    size_t before = graph()->NodeCount();
     ReduceGraph(&r);
     if (i == 0) {
       EXPECT_NE(before, graph()->NodeCount());
     } else {
       EXPECT_EQ(before, graph()->NodeCount());
     }
     Node* nend = graph()->end();
     EXPECT_NE(end, nend);  // end() should be updated too.
 
     Node* nn2 = nend->InputAt(0);
@@ skipping 53 matching lines @@
 
 TEST_F(GraphReducerTest, Forwarding1) {
   Node* n1 = graph()->NewNode(&kOpA0);
   Node* end = graph()->NewNode(&kOpA1, n1);
   graph()->SetEnd(end);
 
   A1Forwarder r;
 
   // Tests A1(x) => x
   for (int i = 0; i < 3; i++) {
-    int before = graph()->NodeCount();
+    size_t before = graph()->NodeCount();
     ReduceGraph(&r);
     EXPECT_EQ(before, graph()->NodeCount());
     EXPECT_EQ(&kOpA0, n1->op());
     EXPECT_EQ(n1, graph()->end());
   }
 }
 
 
 TEST_F(GraphReducerTest, Forwarding2) {
   Node* n1 = graph()->NewNode(&kOpA0);
   Node* n2 = graph()->NewNode(&kOpA1, n1);
   Node* n3 = graph()->NewNode(&kOpA1, n1);
   Node* end = graph()->NewNode(&kOpA2, n2, n3);
   graph()->SetEnd(end);
 
   A1Forwarder r;
 
   // Tests reducing A2(A1(x), A1(y)) => A2(x, y).
   for (int i = 0; i < 3; i++) {
-    int before = graph()->NodeCount();
+    size_t before = graph()->NodeCount();
     ReduceGraph(&r);
     EXPECT_EQ(before, graph()->NodeCount());
     EXPECT_EQ(&kOpA0, n1->op());
     EXPECT_EQ(n1, end->InputAt(0));
     EXPECT_EQ(n1, end->InputAt(1));
     EXPECT_EQ(&kOpA2, end->op());
     EXPECT_EQ(0, n2->UseCount());
     EXPECT_EQ(0, n3->UseCount());
   }
 }
 
 
 TEST_F(GraphReducerTest, Forwarding3) {
   // Tests reducing a chain of A1(A1(A1(A1(x)))) => x.
   for (int i = 0; i < 8; i++) {
     Node* n1 = graph()->NewNode(&kOpA0);
     Node* end = n1;
     for (int j = 0; j < i; j++) {
       end = graph()->NewNode(&kOpA1, end);
     }
     graph()->SetEnd(end);
 
     A1Forwarder r;
 
-    for (int i = 0; i < 3; i++) {
-      int before = graph()->NodeCount();
+    for (size_t i = 0; i < 3; i++) {
+      size_t before = graph()->NodeCount();
       ReduceGraph(&r);
       EXPECT_EQ(before, graph()->NodeCount());
       EXPECT_EQ(&kOpA0, n1->op());
       EXPECT_EQ(n1, graph()->end());
     }
   }
 }
 
 
 TEST_F(GraphReducerTest, ReduceForward1) {
   Node* n1 = graph()->NewNode(&kOpA0);
   Node* n2 = graph()->NewNode(&kOpA1, n1);
   Node* n3 = graph()->NewNode(&kOpA1, n1);
   Node* end = graph()->NewNode(&kOpA2, n2, n3);
   graph()->SetEnd(end);
 
   InPlaceABReducer r;
   B1Forwarder f;
 
   // Tests first reducing A => B, then B1(x) => x.
-  for (int i = 0; i < 3; i++) {
-    int before = graph()->NodeCount();
+  for (size_t i = 0; i < 3; i++) {
+    size_t before = graph()->NodeCount();
     ReduceGraph(&r, &f);
     EXPECT_EQ(before, graph()->NodeCount());
     EXPECT_EQ(&kOpB0, n1->op());
     EXPECT_TRUE(n2->IsDead());
     EXPECT_EQ(n1, end->InputAt(0));
     EXPECT_TRUE(n3->IsDead());
     EXPECT_EQ(n1, end->InputAt(0));
     EXPECT_EQ(&kOpB2, end->op());
     EXPECT_EQ(0, n2->UseCount());
     EXPECT_EQ(0, n3->UseCount());
@@ skipping 11 matching lines @@
 
     if (i == 0) end = graph()->NewNode(&kOpA2, n2, n3);
     if (i == 1) end = graph()->NewNode(&kOpA2, n3, n2);
     if (i == 2) end = graph()->NewNode(&kOpA2, n2, n1);
     if (i == 3) end = graph()->NewNode(&kOpA2, n1, n2);
     if (i == 4) end = graph()->NewNode(&kOpA2, n3, n1);
     if (i == 5) end = graph()->NewNode(&kOpA2, n1, n3);
 
     graph()->SetEnd(end);
 
-    int before = graph()->NodeCount();
+    size_t before = graph()->NodeCount();
     ReduceGraph(&r);
     EXPECT_EQ(before, graph()->NodeCount());
     EXPECT_EQ(&kOpA0, n1->op());
     EXPECT_EQ(&kOpA1, n2->op());
     EXPECT_EQ(&kOpA1, n3->op());
     EXPECT_EQ(&kOpA2, end->op());
     EXPECT_EQ(end, graph()->end());
     EXPECT_LE(end->InputAt(0)->id(), end->InputAt(1)->id());
   }
 }
@@ skipping 74 matching lines @@
   // rerun for changed nodes.
   for (int i = 0; i < 2; i++) {
     Node* n1 = graph()->NewNode(&kOpA0);
     Node* end = graph()->NewNode(&kOpA1, n1);
     graph()->SetEnd(end);
 
     InPlaceABReducer abr;
     InPlaceBCReducer bcr;
 
     // Tests A* => C* with in-place updates.
-    for (int j = 0; j < 3; j++) {
-      int before = graph()->NodeCount();
+    for (size_t j = 0; j < 3; j++) {
+      size_t before = graph()->NodeCount();
       if (i == 0) {
         ReduceGraph(&abr, &bcr);
       } else {
         ReduceGraph(&bcr, &abr);
       }
 
       EXPECT_EQ(before, graph()->NodeCount());
       EXPECT_EQ(&kOpC0, n1->op());
       EXPECT_EQ(&kOpC1, end->op());
       EXPECT_EQ(n1, end->InputAt(0));
     }
   }
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8