Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(706)

Side by Side Diff: tools/testing/dart/test_suite.dart

Issue 11784023: Do not pass VMOptions to dartc (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /** 5 /**
6 * Classes and methods for enumerating and preparing tests. 6 * Classes and methods for enumerating and preparing tests.
7 * 7 *
8 * This library includes: 8 * This library includes:
9 * 9 *
10 * - Creating tests by listing all the Dart files in certain directories, 10 * - Creating tests by listing all the Dart files in certain directories,
(...skipping 1394 matching lines...) Expand 10 before | Expand all | Expand 10 after
1405 "containsLeadingHash": containsLeadingHash, 1405 "containsLeadingHash": containsLeadingHash,
1406 "isolateStubs": isolateStubs, 1406 "isolateStubs": isolateStubs,
1407 "containsDomImport": containsDomImport, 1407 "containsDomImport": containsDomImport,
1408 "isLibraryDefinition": isLibraryDefinition, 1408 "isLibraryDefinition": isLibraryDefinition,
1409 "containsSourceOrImport": containsSourceOrImport, 1409 "containsSourceOrImport": containsSourceOrImport,
1410 "numStaticTypeAnnotations": numStaticTypeAnnotations, 1410 "numStaticTypeAnnotations": numStaticTypeAnnotations,
1411 "numCompileTimeAnnotations": numCompileTimeAnnotations }; 1411 "numCompileTimeAnnotations": numCompileTimeAnnotations };
1412 } 1412 }
1413 1413
1414 List<List<String>> getVmOptions(Map optionsFromFile) { 1414 List<List<String>> getVmOptions(Map optionsFromFile) {
1415 var COMPILERS = const ['none', 'dart2dart', 'dartc']; 1415 var COMPILERS = const ['none', 'dart2dart'];
1416 var RUNTIMES = const ['none', 'vm', 'drt', 'dartium']; 1416 var RUNTIMES = const ['none', 'vm', 'drt', 'dartium'];
1417 var needsVmOptions = COMPILERS.contains(configuration['compiler']) && 1417 var needsVmOptions = COMPILERS.contains(configuration['compiler']) &&
1418 RUNTIMES.contains(configuration['runtime']); 1418 RUNTIMES.contains(configuration['runtime']);
1419 if (!needsVmOptions) return [[]]; 1419 if (!needsVmOptions) return [[]];
1420 final vmOptions = optionsFromFile['vmOptions']; 1420 final vmOptions = optionsFromFile['vmOptions'];
1421 if (configuration['compiler'] != 'dart2dart') return vmOptions; 1421 if (configuration['compiler'] != 'dart2dart') return vmOptions;
1422 // Temporary workaround for race in test suite: tests with different 1422 // Temporary workaround for race in test suite: tests with different
1423 // vm options are still compiled into the same output file which 1423 // vm options are still compiled into the same output file which
1424 // may lead to reads from empty files. 1424 // may lead to reads from empty files.
1425 return [vmOptions[0]]; 1425 return [vmOptions[0]];
(...skipping 380 matching lines...) Expand 10 before | Expand all | Expand 10 after
1806 * $pass tests are expected to pass 1806 * $pass tests are expected to pass
1807 * $failOk tests are expected to fail that we won't fix 1807 * $failOk tests are expected to fail that we won't fix
1808 * $fail tests are expected to fail that we should fix 1808 * $fail tests are expected to fail that we should fix
1809 * $crash tests are expected to crash that we should fix 1809 * $crash tests are expected to crash that we should fix
1810 * $timeout tests are allowed to timeout 1810 * $timeout tests are allowed to timeout
1811 * $compileErrorSkip tests are skipped on browsers due to compile-time error 1811 * $compileErrorSkip tests are skipped on browsers due to compile-time error
1812 """; 1812 """;
1813 print(report); 1813 print(report);
1814 } 1814 }
1815 } 1815 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698