Issue 11784006: Revert "Remove VisitedLink dependency on rest of chrome"

Issue 11784006: Revert "Remove VisitedLink dependency on rest of chrome" (Closed)

Created:
7 years, 11 months ago by boliu

Modified:
7 years, 11 months ago

Reviewers:
brettw, Jói, dhollowa

CC:
chromium-reviews, browser-components-watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Revert "Remove VisitedLink dependency on rest of chrome" r175186 There are memory leaks in this patch in RebuildTableFromDelegate BUG= TBR=brettw@chromium.org,joi@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175217

Patch Set 1 #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+297 lines, -328 lines)			Patch
M	chrome/browser/history/DEPS	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/history/history.h	View	6 chunks	+26 lines, -14 lines	0 comments	Download
M	chrome/browser/history/history.cc	View	10 chunks	+30 lines, -64 lines	0 comments	Download
M	chrome/browser/history/history_backend.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/history/history_backend.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/profiles/profile_dependency_manager.cc	View	2 chunks	+2 lines, -0 lines	0 comments	Download
D	chrome/browser/visitedlink/visitedlink_delegate.h	View	1 chunk	+0 lines, -46 lines	0 comments	Download
M	chrome/browser/visitedlink/visitedlink_event_listener.h	View	2 chunks	+3 lines, -11 lines	0 comments	Download
M	chrome/browser/visitedlink/visitedlink_event_listener.cc	View	4 chunks	+21 lines, -15 lines	0 comments	Download
M	chrome/browser/visitedlink/visitedlink_master.h	View	8 chunks	+19 lines, -41 lines	0 comments	Download
M	chrome/browser/visitedlink/visitedlink_master.cc	View	14 chunks	+46 lines, -35 lines	0 comments	Download
A	chrome/browser/visitedlink/visitedlink_master_factory.h	View	1 chunk	+38 lines, -0 lines	0 comments	Download
A	chrome/browser/visitedlink/visitedlink_master_factory.cc	View	1 chunk	+45 lines, -0 lines	0 comments	Download
M	chrome/browser/visitedlink/visitedlink_perftest.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/visitedlink/visitedlink_unittest.cc	View	29 chunks	+62 lines, -95 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

boliu

Going to wait for linux_clang:compile to succeed, then committing this revert.

7 years, 11 months ago (2013-01-04 22:26:14 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/boliu@chromium.org/11784006/1

7 years, 11 months ago (2013-01-04 22:33:46 UTC) #2

Message was sent while issue was closed.

Change committed as 175217

Expand Messages | Collapse Messages