Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 11784004: Make net/test/test_server correctly report timeouts. (Closed)

Created:
7 years, 11 months ago by Paweł Hajdan Jr.
Modified:
7 years, 11 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, sail+watch_chromium.org
Visibility:
Public.

Description

Make net/test/test_server correctly report timeouts. poll() returns 0 on a timeout, and doesn't set errno in that case, so it makes no sense to use PLOG on a timeout. Also, this change prints the number of bytes already read, to help distinguish between a case where we never receive anything from the server, and a case where we do receive response but not all of it, and the rest gets stuck for some reason (buffering?). BUG=96594 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175204

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M net/test/local_test_server_posix.cc View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Paweł Hajdan Jr.
7 years, 11 months ago (2013-01-04 20:44:12 UTC) #1
Ryan Sleevi
7 years, 11 months ago (2013-01-04 21:45:45 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698