Source/core/frame/csp/CSPSourceList.cpp - Issue 1178373004: 'blob:' URLs should not match 'self' in CSP source expression lists.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/csp/CSPSourceList.cpp

Issue 1178373004: 'blob:' URLs should not match 'self' in CSP source expression lists. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Exclude extensions. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/security/contentSecurityPolicy/filesystem-urls-match-self-expected.txt ('k') | Source/core/frame/csp/CSPSourceListTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/frame/csp/CSPSourceList.cpp

diff --git a/Source/core/frame/csp/CSPSourceList.cpp b/Source/core/frame/csp/CSPSourceList.cpp

index 2879466ff3b4430054087d9fdf14ad832d684493..9caeb9340d6a66a0b0480e6b466375fd44838ca0 100644

--- a/Source/core/frame/csp/CSPSourceList.cpp

+++ b/Source/core/frame/csp/CSPSourceList.cpp

@@ -48,7 +48,7 @@ bool CSPSourceList::matches(const KURL& url, ContentSecurityPolicy::RedirectStat

if (m_allowStar)

return true;

- KURL effectiveURL = SecurityOrigin::shouldUseInnerURL(url) ? SecurityOrigin::extractInnerURL(url) : url;

+ KURL effectiveURL = m_policy->selfMatchesInnerURL() && SecurityOrigin::shouldUseInnerURL(url) ? SecurityOrigin::extractInnerURL(url) : url;

if (m_allowSelf && m_policy->urlMatchesSelf(effectiveURL))

return true;