Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 <?xml version="1.0" encoding="utf-8"?> | 1 <?xml version="1.0" encoding="utf-8"?> |
| 2 <lint> | 2 <lint> |
| 3 <!-- | 3 <!-- |
| 4 STOP! It looks like you want to suppress some lint errors: | 4 STOP! It looks like you want to suppress some lint errors: |
| 5 - Have you tried identifing the offending patch? | 5 - Have you tried identifing the offending patch? |
| 6 Ask the author for a fix and/or revert the patch. | 6 Ask the author for a fix and/or revert the patch. |
| 7 - It is preferred to add suppressions in the code instead of | 7 - It is preferred to add suppressions in the code instead of |
| 8 sweeping it under the rug here. See: | 8 sweeping it under the rug here. See: |
| 9 | 9 |
| 10 http://developer.android.com/tools/debugging/improving-w-lint.html | 10 http://developer.android.com/tools/debugging/improving-w-lint.html |
| (...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 44 <issue id="IconDensities"> | 44 <issue id="IconDensities"> |
| 45 <!-- crbug.com/457918 is tracking missing assets --> | 45 <!-- crbug.com/457918 is tracking missing assets --> |
| 46 <ignore path="components/web_contents_delegate_android/android/java/res/draw able-xxhdpi"/> | 46 <ignore path="components/web_contents_delegate_android/android/java/res/draw able-xxhdpi"/> |
| 47 <ignore path="components/web_contents_delegate_android/android/java/res/draw able-xxxhdpi"/> | 47 <ignore path="components/web_contents_delegate_android/android/java/res/draw able-xxxhdpi"/> |
| 48 <ignore path="content/public/android/java/res/drawable-xxhdpi"/> | 48 <ignore path="content/public/android/java/res/drawable-xxhdpi"/> |
| 49 <ignore path="content/public/android/java/res/drawable-xxxhdpi"/> | 49 <ignore path="content/public/android/java/res/drawable-xxxhdpi"/> |
| 50 <ignore path="chrome/android/java/res/drawable-xxhdpi"/> | 50 <ignore path="chrome/android/java/res/drawable-xxhdpi"/> |
| 51 <ignore path="chrome/android/java/res/drawable-xxxhdpi"/> | 51 <ignore path="chrome/android/java/res/drawable-xxxhdpi"/> |
| 52 <ignore path="ui/android/java/res/drawable-xxhdpi"/> | 52 <ignore path="ui/android/java/res/drawable-xxhdpi"/> |
| 53 <ignore path="ui/android/java/res/drawable-xxxhdpi"/> | 53 <ignore path="ui/android/java/res/drawable-xxxhdpi"/> |
| 54 <ignore regexp=".*: reader_mode_bar_background.9.png, tabs_moved_htc.png, ta bs_moved_nexus.png, tabs_moved_samsung.png$"/> | |
|
pkotwicz
2015/06/17 01:25:48
Now I know how to do these types of suppressions.
| |
| 54 </issue> | 55 </issue> |
| 55 <!-- It is OK for content_shell_apk and chrome_shell_apk to have missing asset s. --> | 56 <!-- It is OK for content_shell_apk and chrome_shell_apk to have missing asset s. --> |
| 56 <issue id="IconLocation"> | 57 <issue id="IconLocation"> |
| 57 <ignore path="content/shell/android/java/res/"/> | 58 <ignore path="content/shell/android/java/res/"/> |
| 58 <ignore path="chrome/android/shell/res/"/> | 59 <ignore path="chrome/android/shell/res/"/> |
| 59 </issue> | 60 </issue> |
| 60 <issue id="InconsistentLayout" severity="ignore"/> | 61 <issue id="InconsistentLayout" severity="ignore"/> |
| 61 <issue id="InflateParams" severity="ignore"/> | 62 <issue id="InflateParams" severity="ignore"/> |
| 62 <issue id="MissingApplicationIcon" severity="ignore"/> | 63 <issue id="MissingApplicationIcon" severity="ignore"/> |
| 63 <issue id="MissingRegistered" severity="ignore"/> | 64 <issue id="MissingRegistered" severity="ignore"/> |
| (...skipping 27 matching lines...) Expand all Loading... | |
| 91 TODO(pkotwicz): Re-enable after the chrome_java and chrome_staging_java | 92 TODO(pkotwicz): Re-enable after the chrome_java and chrome_staging_java |
| 92 targets have been merged. crbug.com/484934 | 93 targets have been merged. crbug.com/484934 |
| 93 --> | 94 --> |
| 94 <ignore path="chrome/android/java/res" /> | 95 <ignore path="chrome/android/java/res" /> |
| 95 </issue> | 96 </issue> |
| 96 <issue id="SignatureOrSystemPermissions" severity="ignore"/> | 97 <issue id="SignatureOrSystemPermissions" severity="ignore"/> |
| 97 <issue id="UnusedAttribute" severity="ignore"/> | 98 <issue id="UnusedAttribute" severity="ignore"/> |
| 98 <issue id="ViewConstructor" severity="ignore"/> | 99 <issue id="ViewConstructor" severity="ignore"/> |
| 99 <issue id="WrongCall" severity="ignore"/> | 100 <issue id="WrongCall" severity="ignore"/> |
| 100 </lint> | 101 </lint> |
| OLD | NEW |