Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1178313004: [remoting-test] Fix It2Me browser test failures. (Closed)

Created:
5 years, 6 months ago by kelvinp
Modified:
5 years, 6 months ago
Reviewers:
anandc, Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[remoting-test] Fix It2Me browser test failures. Currently, we wait for 30s for the session to be connected but we didn't specify any timeout when waiting for session failure. As a result, the default timeout of 5 seconds is used. This CL also makes the test stricter by only failing the test when the current mode matches the expected failure mode. Those tests are passing before, this suggests that it takes longer now for an IT2ME connection to fail, which may be related to the recent signaling change. BUG=486872 Committed: https://crrev.com/1a0e0b3bd05234d15f43da0a5b4f1813755e233b Cr-Commit-Position: refs/heads/master@{#334980}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M remoting/webapp/browser_test/browser_test.js View 1 chunk +6 lines, -3 lines 1 comment Download

Messages

Total messages: 8 (3 generated)
kelvinp
PTAL
5 years, 6 months ago (2015-06-18 01:01:07 UTC) #3
Jamie
lgtm https://codereview.chromium.org/1178313004/diff/1/remoting/webapp/browser_test/browser_test.js File remoting/webapp/browser_test/browser_test.js (right): https://codereview.chromium.org/1178313004/diff/1/remoting/webapp/browser_test/browser_test.js#newcode288 remoting/webapp/browser_test/browser_test.js:288: var onFailure = browserTest.onUIMode(failureMode, SESSION_CONNECTION_TIMEOUT); You've also made ...
5 years, 6 months ago (2015-06-18 01:05:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1178313004/1
5 years, 6 months ago (2015-06-18 01:11:29 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-18 01:44:00 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-18 01:45:05 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1a0e0b3bd05234d15f43da0a5b4f1813755e233b
Cr-Commit-Position: refs/heads/master@{#334980}

Powered by Google App Engine
This is Rietveld 408576698