Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1754)

Unified Diff: cc/video_layer_impl.cc

Issue 11783094: cc: Add point-based UV coordinate on TextureLayer (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/video_layer_impl.cc
diff --git a/cc/video_layer_impl.cc b/cc/video_layer_impl.cc
index 130e6f2460a25cd0b60ce6c9612d6a1c1846addb..3b367032008c7783aa4fe84bfebe009963008dc2 100644
--- a/cc/video_layer_impl.cc
+++ b/cc/video_layer_impl.cc
@@ -224,22 +224,24 @@ void VideoLayerImpl::appendQuads(QuadSink& quadSink, AppendQuadsData& appendQuad
// RGBA software decoder.
const FramePlane& plane = m_framePlanes[media::VideoFrame::kRGBPlane];
bool premultipliedAlpha = true;
- gfx::RectF uvRect(0, 0, texWidthScale, texHeightScale);
+ gfx::PointF uvtl(0, 0);
danakj 2013/01/10 18:12:26 uv_top_left please dont use cryptic abbreviations
Jerome 2013/01/10 19:21:55 Done.
+ gfx::PointF uvbr(texWidthScale, texHeightScale);
danakj 2013/01/10 18:12:26 being a bit unfamiliar with this stuff, i wonder i
Jerome 2013/01/10 19:21:55 Usually UV coordinates are expressed on a per vert
const float opacity[] = {1.0f, 1.0f, 1.0f, 1.0f};
bool flipped = false;
scoped_ptr<TextureDrawQuad> textureQuad = TextureDrawQuad::Create();
- textureQuad->SetNew(sharedQuadState, quadRect, opaqueRect, plane.resourceId, premultipliedAlpha, uvRect, opacity, flipped);
+ textureQuad->SetNew(sharedQuadState, quadRect, opaqueRect, plane.resourceId, premultipliedAlpha, uvtl, uvbr, opacity, flipped);
quadSink.append(textureQuad.PassAs<DrawQuad>(), appendQuadsData);
break;
}
case GL_TEXTURE_2D: {
// NativeTexture hardware decoder.
bool premultipliedAlpha = true;
- gfx::RectF uvRect(0, 0, texWidthScale, texHeightScale);
+ gfx::PointF uvtl(0, 0);
+ gfx::PointF uvbr(texWidthScale, texHeightScale);
const float opacity[] = {1.0f, 1.0f, 1.0f, 1.0f};
bool flipped = false;
scoped_ptr<TextureDrawQuad> textureQuad = TextureDrawQuad::Create();
- textureQuad->SetNew(sharedQuadState, quadRect, opaqueRect, m_externalTextureResource, premultipliedAlpha, uvRect, opacity, flipped);
+ textureQuad->SetNew(sharedQuadState, quadRect, opaqueRect, m_externalTextureResource, premultipliedAlpha, uvtl, uvbr, opacity, flipped);
quadSink.append(textureQuad.PassAs<DrawQuad>(), appendQuadsData);
break;
}
« no previous file with comments | « cc/texture_layer_impl.cc ('k') | content/common/cc_messages.h » ('j') | ui/gfx/size_base_impl.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698