sdk/lib/_internal/compiler/implementation/tree/unparser.dart - Issue 11783089: Fix VariableDefinitions.endToken for formal parameters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/tree/unparser.dart

Issue 11783089: Fix VariableDefinitions.endToken for formal parameters. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Handle for-in. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sdk/lib/_internal/compiler/implementation/scanner/parser.dart ('K') | « sdk/lib/_internal/compiler/implementation/tree/nodes.dart ('k') | tests/compiler/dart2js/resolver_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/tree/unparser.dart

diff --git a/sdk/lib/_internal/compiler/implementation/tree/unparser.dart b/sdk/lib/_internal/compiler/implementation/tree/unparser.dart

index eee95d4e9a2b79e05a5937d39f173294a7452c7a..9c20f2d347124722a2063ae4e07c3ca4f462b61e 100644

--- a/sdk/lib/_internal/compiler/implementation/tree/unparser.dart

+++ b/sdk/lib/_internal/compiler/implementation/tree/unparser.dart

@@ -123,7 +123,7 @@ class Unparser implements Visitor {

add(node.forToken.value);

sb.add('(');

visit(node.initializer);

- if (node.initializer is !Statement) sb.add(';');

+ sb.add(';');

visit(node.conditionStatement);

visit(node.update);

sb.add(')');

@@ -366,9 +366,6 @@ class Unparser implements Visitor {

sb.add(' ');

}

visit(node.definitions);

- if (node.endToken.value == const SourceString(';')) {

- add(node.endToken.value);

- }

}

visitDoWhile(DoWhile node) {