Fix VariableDefinitions.endToken for formal parameters.

sdk/lib/_internal/compiler/implementation/scanner/listener.dart

Index: sdk/lib/_internal/compiler/implementation/scanner/listener.dart
diff --git a/sdk/lib/_internal/compiler/implementation/scanner/listener.dart b/sdk/lib/_internal/compiler/implementation/scanner/listener.dart
index 8f1b67529b608fda54b9c3e51ffc616e7e6b71ca..720067810a22e979487b2bd38478990197dfeaa7 100644
--- a/sdk/lib/_internal/compiler/implementation/scanner/listener.dart
+++ b/sdk/lib/_internal/compiler/implementation/scanner/listener.dart
@@ -105,7 +105,7 @@ class Listener {
   void beginFormalParameter(Token token) {
   }
 
-  void endFormalParameter(Token token, Token thisKeyword) {
+  void endFormalParameter(Token thisKeyword) {
   }
 
   void handleNoFormalParameters(Token token) {
@@ -1263,7 +1263,7 @@ class NodeListener extends ElementListener {
                                            modifiers, compilationUnitElement));
   }
 
-  void endFormalParameter(Token token, Token thisKeyword) {
+  void endFormalParameter(Token thisKeyword) {
     Expression name = popNode();
     if (thisKeyword != null) {
       Identifier thisIdentifier = new Identifier(thisKeyword);
@@ -1275,8 +1275,11 @@ class NodeListener extends ElementListener {
     }
     TypeAnnotation type = popNode();
     Modifiers modifiers = popNode();
-    pushNode(new VariableDefinitions(type, modifiers,
-                                     new NodeList.singleton(name), token));
+    pushNode(
+        new VariableDefinitions(type, modifiers,

[ahe, 2013/01/23 11:26:36]

It is beginning to feel like a hack to use VariableDefinitions node here. WDYT?

[Johnni Winther, 2013/01/28 12:23:24]

It feels better after removing the 'null' for endToken.

+                                new NodeList.singleton(name),
+                                null // Compute dynamically from the node list.
+                                ));
   }
 
   void endFormalParameters(int count, Token beginToken, Token endToken) {