Fix VariableDefinitions.endToken for formal parameters.

sdk/lib/_internal/compiler/implementation/tree/unparser.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of tree;
 
 String unparse(Node node) {
   Unparser unparser = new Unparser();
   unparser.unparse(node);
   return unparser.result;
@@ skipping 344 matching lines @@
   visitVariableDefinitions(VariableDefinitions node) {
     visit(node.modifiers);
     if (!node.modifiers.nodes.isEmpty) {
       sb.add(' ');
     }
     if (node.type != null) {
       visit(node.type);
       sb.add(' ');
     }
     visit(node.definitions);
-    if (node.endToken.value == const SourceString(';')) {
+
+    if (node.endToken != null &&
+        node.endToken.value == const SourceString(';')) {

[ahe, 2013/01/23 11:26:36]

I think you only need to test for "node.endToken != null" now. In other words,
if it has an endToken, it should be printed.

However, don't we already have the same logic for NodeList?

[Johnni Winther, 2013/01/28 12:23:24]

We can remove endToken completely since node.definitions handles it.

       add(node.endToken.value);
     }
   }
 
   visitDoWhile(DoWhile node) {
     add(node.doKeyword.value);
     if (node.body is !Block) sb.add(' ');
     visit(node.body);
     add(node.whileKeyword.value);
     visit(node.condition);
@@ skipping 241 matching lines @@
   }
 
   visitStatement(Statement node) {
     throw 'internal error'; // Should not be called.
   }
 
   visitStringNode(StringNode node) {
     throw 'internal error'; // Should not be called.
   }
 }