Split Date/Time picker values from IME processing since date/time related form values have been com…

content/browser/date_time_chooser.h

Index: content/browser/date_time_chooser.h
diff --git a/content/browser/date_time_chooser.h b/content/browser/date_time_chooser.h
new file mode 100644
index 0000000000000000000000000000000000000000..63886a17c0470cb06ed3067ec9c436b3475cce30
--- /dev/null
+++ b/content/browser/date_time_chooser.h
@@ -0,0 +1,35 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.

[jam, 2013/01/11 23:47:18]

why is there an interface now? i.e. instead of just the implementation only?

[Miguel Garcia, 2013/01/14 16:39:40]

Well, WebContentsImpl holds a member of this class and it did not look right to
add a platform specific implementation directly here (even if it's ifdef-ed for
android). Or perhaps are you asking to have empty implementations of the methods
instead of pure virtual ones? I will change the pure virtual method to an empty
implementation just in case.

[jam, 2013/01/14 17:48:17]

I don't understand the aversion :) I think if we don't need an interface, better
to have less layers.

[Miguel Garcia, 2013/01/14 18:46:38]

Well if you are ok with it I am ok with it :) I have also ifdef-ed the import on
web_contents_impl since it is now platform specific.


On 2013/01/14 17:48:17, John Abd-El-Malek wrote:

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_PUBLIC_BROWSER_DATE_TIME_CHOOSER_H_
+#define CONTENT_PUBLIC_BROWSER_DATE_TIME_CHOOSER_H_
+
+#include <string>
+
+#include "base/basictypes.h"
+
+namespace content {
+
+class ContentViewCore;
+class RenderViewHost;
+
+// An interface for showing date/time picker dialogs.
+class DateTimeChooser {
+ public:
+  DateTimeChooser() {}
+  virtual ~DateTimeChooser() {}
+
+  static DateTimeChooser* Create();
+
+  // Shows a date/time dialog of a given type with an initial value
+  virtual void ShowDialog(ContentViewCore* content,
+                          RenderViewHost* sender,
+                          int type, const std::string& value) = 0;
+ private:
+  DISALLOW_COPY_AND_ASSIGN(DateTimeChooser);
+};
+
+}  // namespace content
+
+#endif  // CONTENT_PUBLIC_BROWSER_DATE_TIME_CHOOSER_H_