Split Date/Time picker values from IME processing since date/time related form values have been com…

content/common/view_messages.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // IPC messages for page rendering.
 // Multiply-included message file, hence no include guard.
 
 #include "base/process.h"
 #include "base/shared_memory.h"
 #include "base/string16.h"
@@ skipping 1972 matching lines @@
 // ViewMsg_EnumerateDirectoryResponse message.
 IPC_MESSAGE_ROUTED2(ViewHostMsg_EnumerateDirectory,
                     int /* request_id */,
                     FilePath /* file_path */)
 
 // Tells the browser to move the focus to the next (previous if reverse is
 // true) focusable element.
 IPC_MESSAGE_ROUTED1(ViewHostMsg_TakeFocus,
                     bool /* reverse */)
 
+// Required for opening a date/time dialog
+IPC_MESSAGE_ROUTED2(ViewHostMsg_OpenDateTimeDialog,
+                    int /* dialog type */,

[jam, 2013/01/14 21:10:55]

nit: here and below, the convention is to put the parameter name in the
dispatching function inside the comment (so type, and value)

[Miguel Garcia, 2013/01/17 12:17:40]

Done.

+                    std::string /* initial value */)

[palmer, 2013/01/14 23:53:35]

I'd rather send plain old data (e.g. an int of seconds since the epoch), or a
specific Date/Time/DateTime object, rather than a pre-baked *representation* of
the value. From the sender side of the code, we don't know how the recipient is
going to interpret/interpolate this value — what if it's a (cross-site
scriptable!) WebView someday, instead of a native Android GUI widget? What if
the string is formatted for the wrong locale? That kind of thing.

So, send the specific type you *mean*. That also has the benefit of bounding the
size of the sent object, which is important in IPC.

[Miguel Garcia, 2013/01/17 12:17:40]

As agreed, I'll do this in a separate patch.

On 2013/01/14 23:53:35, Chris P. wrote:

+
 // Required for updating text input state.
 IPC_MESSAGE_ROUTED1(ViewHostMsg_TextInputStateChanged,
                     ViewHostMsg_TextInputState_Params /* input state params */)
 
 // Message sent when the IME text composition range changes.
 IPC_MESSAGE_ROUTED2(ViewHostMsg_ImeCompositionRangeChanged,
                     ui::Range /* composition range */,
                     std::vector<gfx::Rect> /* character bounds */)
 
 // Required for cancelling an ongoing input method composition.
@@ skipping 372 matching lines @@
                      int /* arb_robustness_status_code */)
 
 #if defined(OS_WIN)
 // Request that the given font characters be loaded by the browser so it's
 // cached by the OS. Please see RenderMessageFilter::OnPreCacheFontCharacters
 // for details.
 IPC_SYNC_MESSAGE_CONTROL2_0(ViewHostMsg_PreCacheFontCharacters,
                             LOGFONT /* font_data */,
                             string16 /* characters */)
 #endif