Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 11783085: Extends IBusLookupTable to handle IsEqual/CopyFrom. (Closed)

Created:
7 years, 11 months ago by Seigo Nonaka
Modified:
7 years, 11 months ago
Reviewers:
satorux1
CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

Extends IBusLookupTable to handle IsEqual/CopyFrom. These function is necessary for InputMethodLookupTable removal. This patch also shorten HORIZONTAL/VERTICAL macro which is too long and prefix does not mean much. BUG=None TEST=ran chromeos_unittests. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177089

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -11 lines) Patch
M chrome/browser/chromeos/input_method/ibus_ui_controller.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_engine_ibus.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M chromeos/dbus/ibus/ibus_lookup_table.h View 1 2 chunks +8 lines, -2 lines 0 comments Download
M chromeos/dbus/ibus/ibus_lookup_table.cc View 1 chunk +33 lines, -1 line 0 comments Download
M chromeos/dbus/ibus/ibus_lookup_table_unittest.cc View 4 chunks +123 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Seigo Nonaka
7 years, 11 months ago (2013-01-11 03:17:19 UTC) #1
Seigo Nonaka
ping, just in case. This patch is required for https://codereview.chromium.org/11857008/ Thanks.
7 years, 11 months ago (2013-01-15 23:36:32 UTC) #2
satorux1
LGTM with a nit https://codereview.chromium.org/11783085/diff/1/chromeos/dbus/ibus/ibus_lookup_table.h File chromeos/dbus/ibus/ibus_lookup_table.h (right): https://codereview.chromium.org/11783085/diff/1/chromeos/dbus/ibus/ibus_lookup_table.h#newcode108 chromeos/dbus/ibus/ibus_lookup_table.h:108: // Copy |table| to myself. ...
7 years, 11 months ago (2013-01-15 23:58:47 UTC) #3
Seigo Nonaka
Thank you for your review! Submitting... https://codereview.chromium.org/11783085/diff/1/chromeos/dbus/ibus/ibus_lookup_table.h File chromeos/dbus/ibus/ibus_lookup_table.h (right): https://codereview.chromium.org/11783085/diff/1/chromeos/dbus/ibus/ibus_lookup_table.h#newcode108 chromeos/dbus/ibus/ibus_lookup_table.h:108: // Copy |table| ...
7 years, 11 months ago (2013-01-16 01:25:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/11783085/6001
7 years, 11 months ago (2013-01-16 01:29:43 UTC) #5
commit-bot: I haz the power
Retried try job too often on win for step(s) compile
7 years, 11 months ago (2013-01-16 03:28:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/11783085/6001
7 years, 11 months ago (2013-01-16 03:30:26 UTC) #7
commit-bot: I haz the power
7 years, 11 months ago (2013-01-16 05:31:16 UTC) #8
Message was sent while issue was closed.
Change committed as 177089

Powered by Google App Engine
This is Rietveld 408576698