Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(669)

Issue 11783076: [net/dns] Add per-address-family histograms AsyncDNS.ResolveSuccess_FAMILY_* (Closed)

Created:
7 years, 11 months ago by szym
Modified:
7 years, 11 months ago
Reviewers:
pauljensen
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, mmenke
Visibility:
Public.

Description

[net/dns] Add per-address-family histograms AsyncDNS.ResolveSuccess_FAMILY_* and per-qtype histograms AsyncDNS.TransactionSuccess_*. Currently observed AsyncDNS.ResolveSuccess (duration of DnsTask) is almost twice as long as AsyncDNS.TransactionSuccess (duration of DnsTransaction). This could be attributed to dual-stack resolutions which involve two DnsTransactions, but at the same time the difference between DNS.ResolveSuccess_FAMILY_IPV4 and ..._UNSPEC (duration of ProcTask) is much less pronounced suggesting that SystemDNS resolves names on dual-stack hosts differently than AsyncDNS. This measurement will allow us to determine how much of the observed overhead of DnsTask over DnsTransaction can be attributed to dual-stack lookups. BUG=169257 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176137

Patch Set 1 #

Patch Set 2 : add TransactionSuccess_* histograms #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -4 lines) Patch
M net/base/host_resolver_impl.cc View 1 2 chunks +23 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
szym
7 years, 11 months ago (2013-01-09 23:16:02 UTC) #1
szym
Switching reviewer from Matt to Paul with whom I have already briefly discussed this idea.
7 years, 11 months ago (2013-01-09 23:18:04 UTC) #2
pauljensen
lgtm. In your description you should change "must" to "much". Would be nice if there ...
7 years, 11 months ago (2013-01-10 14:58:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/szym@chromium.org/11783076/7001
7 years, 11 months ago (2013-01-10 16:32:54 UTC) #4
commit-bot: I haz the power
7 years, 11 months ago (2013-01-10 18:53:41 UTC) #5
Retried try job too often on linux_chromeos for step(s) browser_tests

Powered by Google App Engine
This is Rietveld 408576698